New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-6199 | ci: migrate the Dockerfile from the repo release to rosa #1934
OCM-6199 | ci: migrate the Dockerfile from the repo release to rosa #1934
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1934 +/- ##
==========================================
+ Coverage 21.69% 21.71% +0.01%
==========================================
Files 118 118
Lines 19804 19809 +5
==========================================
+ Hits 4297 4302 +5
Misses 15186 15186
Partials 321 321 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small NP inline, other than that looks good
79b0eb9
to
f154dce
Compare
update update update
f154dce
to
2f4f852
Compare
@yasun1: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ciaranRoche, yasun1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.