Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-6542 | feat: add cmd to attach policy #1941

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

marcolan018
Copy link
Contributor

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 55.61798% with 79 lines in your changes are missing coverage. Please review.

Project coverage is 23.22%. Comparing base (26d550d) to head (0f226fb).
Report is 14 commits behind head on master.

Files Patch % Lines
pkg/policy/policy_service.go 59.45% 22 Missing and 8 partials ⚠️
cmd/attach/policy/cmd.go 73.91% 13 Missing and 5 partials ⚠️
pkg/aws/mock_client.go 0.00% 18 Missing ⚠️
pkg/aws/client.go 37.50% 5 Missing ⚠️
pkg/aws/quota.go 0.00% 5 Missing ⚠️
pkg/test/helpers.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1941      +/-   ##
==========================================
+ Coverage   22.51%   23.22%   +0.70%     
==========================================
  Files         131      136       +5     
  Lines       20840    21160     +320     
==========================================
+ Hits         4692     4914     +222     
- Misses      15797    15879      +82     
- Partials      351      367      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you have a look at how we structured the describe autoscaler cmd, so we can align this new command to use the new runner method 🙏

@marcolan018 marcolan018 force-pushed the ocm-6542 branch 3 times, most recently from 5f3005c to c79cf8c Compare April 18, 2024 06:21
cmd/attach/policy/cmd.go Outdated Show resolved Hide resolved
cmd/attach/policy/cmd.go Outdated Show resolved Hide resolved
cmd/attach/policy/cmd.go Outdated Show resolved Hide resolved
cmd/attach/policy/cmd.go Outdated Show resolved Hide resolved
cmd/attach/policy/cmd.go Outdated Show resolved Hide resolved
pkg/test/helpers.go Outdated Show resolved Hide resolved
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2024
@marcolan018 marcolan018 force-pushed the ocm-6542 branch 2 times, most recently from 1e431e2 to db682f6 Compare April 22, 2024 08:01
@marcolan018
Copy link
Contributor Author

@davidleerh @ciaranRoche @robpblake @gdbranco
Can you help to review this pr again? I completed changes based on your comments including:

  • support multiple policy attach in one command
  • check service quota for policy per role before attach
  • code refactoring to adopt the latest defaultRunner pattern

@davidleerh
Copy link
Contributor

aside from few nit picks with error messages, LGTM overall.
Manually tested the flow to see it working as expected.

@marcolan018 marcolan018 force-pushed the ocm-6542 branch 4 times, most recently from e528fd7 to 4dd80a9 Compare April 23, 2024 00:37
Signed-off-by: marcolan018 <llan@redhat.com>
Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

@marcolan018: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@davidleerh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidleerh, marcolan018

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 93a653f into openshift:master Apr 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants