-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-6542 | feat: add cmd to attach policy #1941
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1941 +/- ##
==========================================
+ Coverage 22.51% 23.22% +0.70%
==========================================
Files 131 136 +5
Lines 20840 21160 +320
==========================================
+ Hits 4692 4914 +222
- Misses 15797 15879 +82
- Partials 351 367 +16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you have a look at how we structured the describe autoscaler
cmd, so we can align this new command to use the new runner method 🙏
5f3005c
to
c79cf8c
Compare
1e431e2
to
db682f6
Compare
@davidleerh @ciaranRoche @robpblake @gdbranco
|
aside from few nit picks with error messages, LGTM overall. |
e528fd7
to
4dd80a9
Compare
Signed-off-by: marcolan018 <llan@redhat.com>
@marcolan018: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidleerh, marcolan018 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/OCM-6542