Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-7498 | test: automate id:OCP-72715 create/edit nodepool with node… #1948

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

aaraj7
Copy link
Contributor

@aaraj7 aaraj7 commented Apr 19, 2024

OCM-7498 | test: automate id:OCP-72715 create/edit nodepool with node_drain_grace_period to HCP cluster via ROSA cli can work well

output log :- https://privatebin.corp.redhat.com/?1ad49d4e676ed805#8v53avRQLUaTRr6uunhpBqV9fUjhSbgD5qQtEeNxzmCC

@openshift-ci openshift-ci bot requested review from tzhou5 and yuwang-RH April 19, 2024 04:28
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.42%. Comparing base (73ec2f3) to head (08a02c9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1948   +/-   ##
=======================================
  Coverage   22.42%   22.42%           
=======================================
  Files         126      126           
  Lines       20113    20113           
=======================================
  Hits         4511     4511           
  Misses      15254    15254           
  Partials      348      348           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yingzhanredhat
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
…_drain_grace_period to HCP cluster via ROSA cli can work well
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

@aaraj7: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yuwang-RH
Copy link
Member

lgtm

@yuwang-RH
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaraj7, yingzhanredhat, yuwang-RH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit dc8a0f8 into openshift:master Apr 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants