Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-6543 | feat: detach cmd to detach policy #1961

Merged
merged 1 commit into from Apr 26, 2024

Conversation

marcolan018
Copy link
Contributor

@marcolan018 marcolan018 changed the title (Draft)OCM-6543 | feat: detach cmd to attach policy OCM-6543 | feat: detach cmd to attach policy Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 67.96875% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 23.49%. Comparing base (93a653f) to head (85834eb).
Report is 9 commits behind head on master.

Files Patch % Lines
pkg/policy/policy_service.go 71.66% 13 Missing and 4 partials ⚠️
cmd/detach/policy/cmd.go 75.43% 10 Missing and 4 partials ⚠️
pkg/aws/mock_client.go 0.00% 8 Missing ⚠️
pkg/aws/client.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1961      +/-   ##
==========================================
+ Coverage   23.22%   23.49%   +0.27%     
==========================================
  Files         136      137       +1     
  Lines       21160    21267     +107     
==========================================
+ Hits         4914     4997      +83     
- Misses      15879    15899      +20     
- Partials      367      371       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcolan018 marcolan018 changed the title OCM-6543 | feat: detach cmd to attach policy OCM-6543 | feat: detach cmd to detach policy Apr 25, 2024
@davidleerh
Copy link
Contributor

added minor np comments but overall lgtm.
Was able to manually validate the command works as expected.

@marcolan018
Copy link
Contributor Author

@davidleerh thanks for the review, can you help to re-review the latest change? Thanks

Signed-off-by: marcolan018 <llan@redhat.com>
Copy link
Contributor

openshift-ci bot commented Apr 26, 2024

@marcolan018: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@davidleerh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
Copy link
Contributor

openshift-ci bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidleerh, marcolan018

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 796b595 into openshift:master Apr 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants