New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-6543 | feat: detach cmd to detach policy #1961
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1961 +/- ##
==========================================
+ Coverage 23.22% 23.49% +0.27%
==========================================
Files 136 137 +1
Lines 21160 21267 +107
==========================================
+ Hits 4914 4997 +83
- Misses 15879 15899 +20
- Partials 367 371 +4 ☔ View full report in Codecov by Sentry. |
added minor np comments but overall lgtm. |
@davidleerh thanks for the review, can you help to re-review the latest change? Thanks |
Signed-off-by: marcolan018 <llan@redhat.com>
@marcolan018: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidleerh, marcolan018 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/OCM-6543
Signed-off-by: marcolan018 llan@redhat.com