Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-5247 | fix: error message for unmanaged policies #1963

Merged
merged 1 commit into from Apr 26, 2024

Conversation

chenz4027
Copy link
Contributor

@openshift-ci openshift-ci bot requested review from den-rgb and oriAdler April 24, 2024 17:29
Signed-off-by: Maggie Chen <magchen@redhat.com>
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.48%. Comparing base (59e94e8) to head (4ff4c42).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1963      +/-   ##
==========================================
+ Coverage   23.22%   23.48%   +0.26%     
==========================================
  Files         136      137       +1     
  Lines       21160    22051     +891     
==========================================
+ Hits         4914     5179     +265     
- Misses      15879    16464     +585     
- Partials      367      408      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
Copy link
Contributor

openshift-ci bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenz4027, ciaranRoche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024
Copy link
Contributor

openshift-ci bot commented Apr 26, 2024

@chenz4027: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 7194f17 into openshift:master Apr 26, 2024
12 checks passed
@chenz4027 chenz4027 deleted the OCM-5247-fix branch May 9, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants