Fix upgrade issue #618
Fix upgrade issue #618
Conversation
openshift-ci
bot
added
the
approved
|
@vkareh @ciaranRoche PTAL |
cmd/upgrade/accountroles/cmd.go
Outdated
|
|
||
| flags.StringVarP( | ||
| &args.clusterID, | ||
| "clusterID", |
There was a problem hiding this comment.
Why --clusterID - we always use --cluster (and there's ocm.AddClusterFlag(Cmd)) for that.
There was a problem hiding this comment.
@vkareh that is marked as required in AddClusterFlag and we need it hidden just for boilerplate code around upgrade cluster like displayed error message with proper cluster id etc
There was a problem hiding this comment.
@vkareh you are right we dont need it since we are passing as arguments. PTAL
| @@ -1472,6 +1472,9 @@ func (c *awsClient) validateRoleUpgradeVersionCompatibility(roleName string, | |||
| return false, err | |||
| } | |||
| for _, attachedPolicy := range attachedPolicies { | |||
| if attachedPolicy.PolicyArn == "" { | |||
There was a problem hiding this comment.
This is the main fix for the issue all others are just refactoring
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pvasant, vkareh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pvasant: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
https://issues.redhat.com/browse/SDA-5570