build: Add verify target

[frobware]

Add verify build target that checks for:

• gofmt
• go module correctness

Ran make verify and fixed the one formatting change.

[ironcladlou]

Nice, thanks... guess we'll need a corresponding PR to the release repo to create the verify job.

/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, ironcladlou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ironcladlou]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[frobware]

Nice, thanks... guess we'll need a corresponding PR to the release repo to create the verify job.

I did both, obviously need this first.

openshift/release#8384

[frobware]

/retest

[ironcladlou]

I did both, obviously need this first.

(sidebar) it's actually a bit of chicken and egg? Since you can't test the release change against this PR, it seems at least possible if you commit this first, PRs after the release merge could fail because of some error in verify we weren't able to test as part of the release PR...

On t he other hand, if you commit release first, all PRs would be blocked until you have one that successfully passes the new verify job.

Either way we always sort it out, just makes me wonder if there's a way commit this first and then rehearse the release job with e2e tests against master which now contains the verify target?