Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1825354: Removes ALPN from haproxy frontends #121

Merged
merged 1 commit into from Apr 24, 2020
Merged

Bug 1825354: Removes ALPN from haproxy frontends #121

merged 1 commit into from Apr 24, 2020

Conversation

danehans
Copy link
Contributor

Removes alpn h2,http/1.1 from frontend fe_sni and fe_no_sni.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 23, 2020
@openshift-ci-robot
Copy link
Contributor

@danehans: This pull request references Bugzilla bug 1825354, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1825354: Removes ALPN from haproxy frontends

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah
Copy link
Contributor

Miciah commented Apr 23, 2020 •
edited

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 23, 2020
@Miciah Miciah mentioned this pull request Apr 23, 2020
Closed
@danehans
Copy link
Contributor Author

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

@danehans: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danehans
Copy link
Contributor Author

prow/images job failed with:

{"component":"entrypoint","file":"prow/entrypoint/run.go:168","func":"k8s.io/test-infra/prow/entrypoint.Options.ExecuteProcess","level":"error","msg":"Entrypoint received interrupt: terminated","time":"2020-04-23T00:05:24Z"}

/retest

@Miciah
Copy link
Contributor

Miciah commented Apr 23, 2020 •
edited 

error: error creating buildah builder: Error initializing source docker://registry.svc.ci.openshift.org/ci/clonerefs@sha256:bf6048c8021727df5d880737f59eb93bb07c6cb6c65ee1876919c404d6d641c2: error pinging docker registry registry.svc.ci.openshift.org: Get https://registry.svc.ci.openshift.org/v2/: dial tcp 35.196.103.194:443: i/o timeout

/retest

@danehans
Copy link
Contributor Author

e2e-aws job failed due to:

fail [github.com/openshift/origin/test/extended/prometheus/prometheus_builds.go:125]: Unexpected error:
    <*errors.errorString | 0xc001496e70>: {
        s: "host command failed: error running /usr/bin/kubectl --server=https://api.ci-op-nlilgkp2-f04fb.origin-ci-int-aws.dev.rhcloud.com:6443 --kubeconfig=/var/run/secrets/ci.openshift.io/multi-stage/kubeconfig exec --namespace=e2e-test-prometheus-pqsb5 execpodnmzx4 -- /bin/sh -x -c curl -s -k -H 'Authorization: Bearer eyJhbGciOiJSUzI1NiIsImtpZCI6IklhV3c3T2tNLWRub3RwWGwwVmRHTV9QY0NZeWU4WUpzcTJNYzVjRm1YRWMifQ.eyJpc3MiOiJrdWJlcm5ldGVzL3NlcnZpY2VhY2NvdW50Iiwia3ViZXJuZXRlcy5pby9zZXJ2aWNlYWNjb3VudC9uYW1lc3BhY2UiOiJvcGVuc2hpZnQtbW9uaXRvcmluZyIsImt1YmVybmV0ZXMuaW8vc2VydmljZWFjY291bnQvc2VjcmV0Lm5hbWUiOiJwcm9tZXRoZXVzLWFkYXB0ZXItdG9rZW4tbG54aHMiLCJrdWJlcm5ldGVzLmlvL3NlcnZpY2VhY2NvdW50L3NlcnZpY2UtYWNjb3VudC5uYW1lIjoicHJvbWV0aGV1cy1hZGFwdGVyIiwia3ViZXJuZXRlcy5pby9zZXJ2aWNlYWNjb3VudC9zZXJ2aWNlLWFjY291bnQudWlkIjoiMzU1NjUwYjgtZDYwNS00ZTEyLWFlYzUtMDdjNDQ4NmY5ZTIzIiwic3ViIjoic3lzdGVtOnNlcnZpY2VhY2NvdW50Om9wZW5zaGlmdC1tb25pdG9yaW5nOnByb21ldGhldXMtYWRhcHRlciJ9.ny8Du3HccJU2Me1Bc3gJ6EMEk9c9rupab8oxzo6f66r3KCdY0gxGnXOFfpZTicxD0tV2VbBKV-7XRMY_msrDBI75aJXUJ9LBdqsd6L_OWfQcFF6C2mpHTVAgC2phr6oRWeZ93x8W1FD3nU2aPre4zDQFzx-4uziCmIUnOuaZCSmdQUHinEjRL3WxN_m59fUBW5QmnspYZdssFcjsve7SwQkTJ0Bk59L0_vXEyWhyxlVX-9fEopoH-iLThKu_cDVcP8uIhPSfGTE2ztoFAKAKD_rGyCUo3zE0YVYQUK48OrtGh5ZCHA5FKcjbn-_5iksv-C7xZVkJ8KT6iMuSlg0Wlw' \"https://prometheus-k8s.openshift-monitoring.svc:9091/api/v1/query?query=ALERTS%7Balertname%21~%22Watchdog%7CAlertmanagerReceiversNotConfigured%7CPrometheusRemoteWriteDesiredShards%22%2Calertstate%3D%22firing%22%2Cseverity%21%3D%22info%22%7D+%3E%3D+1\":\nCommand stdout:\n\nstderr:\nThe connection to the server api.ci-op-nlilgkp2-f04fb.origin-ci-int-aws.dev.rhcloud.com:6443 was refused - did you specify the right host or port?\n\nerror:\nexit status 1\n",
    }

/test e2e-aws

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@Miciah
Copy link
Contributor

Miciah commented Apr 23, 2020

Last run shows the h2spec tests failing, which is to be expected till openshift/origin#24913 merges.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@Miciah
Copy link
Contributor

Miciah commented Apr 23, 2020

/hold

Let's not keep failing on h2spec.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2020
@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 24, 2020
Merged
@Miciah
Copy link
Contributor

Miciah commented Apr 24, 2020

openshift/origin#24913 has merged.
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@Miciah
Copy link
Contributor

Miciah commented Apr 24, 2020 •
edited

These tests are still failing:

[sig-network-edge][Conformance][Area:Networking][Feature:Router] The HAProxy router should pass the gRPC interoperability tests [Suite:openshift/conformance/parallel/minimal]
[sig-network-edge][Conformance][Area:Networking][Feature:Router] The HAProxy router should pass the h2spec conformance tests [Suite:openshift/conformance/parallel/minimal]

But the skip worked in the last openshift/origin#24913 test run:

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/24913/pull-ci-openshift-origin-master-e2e-gcp/7467

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3a2eb6d into openshift:master Apr 24, 2020
@openshift-ci-robot
Copy link
Contributor

@danehans: All pull requests linked via external trackers have merged: openshift/origin#24913, openshift/router#121. Bugzilla bug 1825354 has been moved to the MODIFIED state.

In response to this:

Bug 1825354: Removes ALPN from haproxy frontends

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 24, 2020
Closed
@openshift-cherrypick-robot
Copy link

@danehans: new pull request created: #124

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@pecameron pecameron Awaiting requested review from pecameron

Assignees

@Miciah Miciah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@danehans @openshift-ci-robot @Miciah @openshift-cherrypick-robot @openshift-bot @openshift-merge-robot