Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile.rhel8 #155

Merged
merged 1 commit into from Jul 28, 2020
Merged

Conversation

yselkowitz
Copy link
Contributor

A separate file is required, as the changes necessary for building with
RHEL 8 content are not compatible with RHEL 7.

A separate file is required, as the changes necessary for building with
RHEL 8 content are not compatible with RHEL 7.
@yselkowitz
Copy link
Contributor Author

/retest

6 similar comments
@yselkowitz
Copy link
Contributor Author

/retest

@yselkowitz
Copy link
Contributor Author

/retest

@yselkowitz
Copy link
Contributor Author

/retest

@yselkowitz
Copy link
Contributor Author

/retest

@yselkowitz
Copy link
Contributor Author

/retest

@yselkowitz
Copy link
Contributor Author

/retest

@yselkowitz
Copy link
Contributor Author

/assign @knobunc

@yselkowitz
Copy link
Contributor Author

/retest

@sdodson
Copy link
Member

sdodson commented Jul 28, 2020

/lgtm
This is net new.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
@sdodson sdodson added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: sdodson, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@crawford
Copy link

From the logs:

Downloading packages:
http://base-4-6.ocp.svc/rhel-server-ose/Packages/haproxy-2.0.14-1.el7__x86_64/haproxy20-2.0.14-1.el7.x86_64.rpm: [Errno 14] HTTP Error 404 - Not Found

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0016d84 into openshift:master Jul 28, 2020
@frobware
Copy link
Contributor

From the logs:

Downloading packages:
http://base-4-6.ocp.svc/rhel-server-ose/Packages/haproxy-2.0.14-1.el7__x86_64/haproxy20-2.0.14-1.el7.x86_64.rpm: [Errno 14] HTTP Error 404 - Not Found

If this is for RHEL 8 shouldn't this pick up a .el8 rpm?

@frobware
Copy link
Contributor

If this is for RHEL 8 shouldn't this pick up a .el8 rpm?

We have a .el8 build here: https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=1269195

@sdodson
Copy link
Member

sdodson commented Jul 30, 2020

Those logs look like they're still from the rhel7 build. I think there needs to be a change to CI build infra to start realizing all of these changes.

@yselkowitz
Copy link
Contributor Author

That will come once everything else is in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants