Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.4] Bug 1879122: haproxy 503 error page: replace all LF by CRLF to be fully RFC compliant #182

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #140

/assign sgreene570

@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1852728 has been cloned as Bugzilla bug 1879122. Retitling PR to link against new bug.
/retitle [release-4.4] Bug 1879122: haproxy 503 error page: replace all LF by CRLF to be fully RFC compliant

In response to this:

[release-4.4] Bug 1852728: haproxy 503 error page: replace all LF by CRLF to be fully RFC compliant

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] Bug 1852728: haproxy 503 error page: replace all LF by CRLF to be fully RFC compliant [release-4.4] Bug 1879122: haproxy 503 error page: replace all LF by CRLF to be fully RFC compliant Sep 15, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 15, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1879122, which is invalid:

  • expected dependent Bugzilla bug 1852728 to target a release in 4.5.0, 4.5.z, but it targets "4.6.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.4] Bug 1879122: haproxy 503 error page: replace all LF by CRLF to be fully RFC compliant

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 15, 2020
@sgreene570
Copy link

#181 (comment)
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2020
@sgreene570
Copy link

Going to do this manually.
Probably witnessing https://stackoverflow.com/questions/1967370/git-replacing-lf-with-crlf
/close

@openshift-ci-robot
Copy link
Contributor

@sgreene570: Closed this PR.

In response to this:

Going to do this manually.
Probably witnessing https://stackoverflow.com/questions/1967370/git-replacing-lf-with-crlf
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants