Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1880103: Bump deps for Kube 1.19 #187

Merged
merged 3 commits into from Sep 19, 2020
Merged

Bug 1880103: Bump deps for Kube 1.19 #187

merged 3 commits into from Sep 19, 2020

Conversation

sgreene570
Copy link

Bumps deps in go.mod to k8s 1.19.

The controller-runtime bump broke pkg/router/controller/status_test.go. To fix this issue, this PR adds a method stub for SetWatchErrorHandler(...) to the test's type fakeInformer.

/assign @Miciah @danehans
/cc @frobware

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 17, 2020
@openshift-ci-robot
Copy link
Contributor

@sgreene570: This pull request references Bugzilla bug 1880103, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1880103: Bump deps for Kube 1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 17, 2020
@sgreene570
Copy link
Author

/test e2e-upgrade

@sgreene570 sgreene570 mentioned this pull request Sep 18, 2020
Merged
@sgreene570 sgreene570 force-pushed the kube-1.19-bump branch 2 times, most recently from ce1395d to 2cd14a9 Compare September 18, 2020 16:57
@sgreene570
go.mod: Bump deps for kube 1.19
61f4149 
Also bumps openshift/library-go to
openshift/library-go@c1de486
to rectify an expired dependency.
@sgreene570
vendor: Bump deps for kube 1.19
232bcd1 
Also bumps openshift/library-go to
openshift/library-go@c1de486
to rectify an expired dependency.
@sgreene570
Copy link
Author

/test e2e

@sgreene570
Fix status_test.go fakeInformer for kube client-go 1.19
fdc6540 
Add a method stub for `SetWatchErrorHandler` in
pkg/routjer/controller/status_test.go
@Miciah
Copy link
Contributor

Miciah commented Sep 19, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6d24b5b into openshift:master Sep 19, 2020
@openshift-ci-robot
Copy link
Contributor

@sgreene570: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1880103 has not been moved to the MODIFIED state.

In response to this:

Bug 1880103: Bump deps for Kube 1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Sep 21, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frobware frobware Awaiting requested review from frobware

Assignees

@danehans danehans

@Miciah Miciah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sgreene570 @openshift-ci-robot @Miciah @openshift-bot @danehans @openshift-merge-robot