[release-4.6] Bug 1896167: metrics: Rework template_router_reload_failure metric #215

openshift-cherrypick-robot · 2020-11-09T21:15:02Z

This is an automated cherry-pick of #209

/assign sgreene570

pkg/router/template/router.go: Replace the current template_router_reload_fails counter metric with a new gauge metric, titled template_router_reload_failure, that tracks the result of the most recent HAProxy reload. If a reload fails, the template_router_reload_failure metric will be set to 1 until a successful reload sets the metric to 0. Previously, the template_router_reload_fails counter metric would monotonically increase when an HAProxy reload failed. This counter metric is difficult to alert on since an increasing counter essentially gives no indication that the reload failures have been resolved. This new boolean based metric is trivial to properly alert on since the metric will hold "1" if and only if the router is _not_ successfully reloading.

openshift-ci-robot · 2020-11-09T21:15:14Z

@openshift-cherrypick-robot: Bugzilla bug 1892338 has been cloned as Bugzilla bug 1896167. Retitling PR to link against new bug.
/retitle [release-4.6] Bug 1896167: metrics: Rework template_router_reload_failure metric

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-11-09T21:15:35Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1896167, which is invalid:

expected dependent Bugzilla bug 1892338 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2020-11-12T09:29:14Z

/lgtm

openshift-ci-robot · 2020-11-12T09:29:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Miciah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-11-12T09:45:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-12T09:58:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-13T01:00:37Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-13T01:00:41Z

@openshift-bot: This pull request references Bugzilla bug 1896167, which is invalid:

expected dependent Bugzilla bug 1892338 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-14T01:00:40Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-14T01:00:43Z

@openshift-bot: This pull request references Bugzilla bug 1896167, which is invalid:

expected dependent Bugzilla bug 1892338 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-15T01:01:16Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-15T01:01:20Z

@openshift-bot: This pull request references Bugzilla bug 1896167, which is invalid:

expected dependent Bugzilla bug 1892338 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-16T01:01:17Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-16T01:01:20Z

@openshift-bot: This pull request references Bugzilla bug 1896167, which is invalid:

expected dependent Bugzilla bug 1892338 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-17T01:01:18Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-17T01:01:21Z

@openshift-bot: This pull request references Bugzilla bug 1896167, which is invalid:

expected dependent Bugzilla bug 1892338 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-18T01:00:23Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-18T01:00:26Z

@openshift-bot: This pull request references Bugzilla bug 1896167, which is invalid:

expected dependent Bugzilla bug 1892338 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-19T01:01:14Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-19T01:01:18Z

@openshift-bot: This pull request references Bugzilla bug 1896167, which is invalid:

expected dependent Bugzilla bug 1892338 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-20T01:01:17Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-20T01:01:20Z

@openshift-bot: This pull request references Bugzilla bug 1896167, which is invalid:

expected dependent Bugzilla bug 1892338 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-21T01:00:51Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-21T01:00:55Z

@openshift-bot: This pull request references Bugzilla bug 1896167, which is invalid:

expected dependent Bugzilla bug 1892338 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-22T01:00:57Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-22T01:01:01Z

@openshift-bot: This pull request references Bugzilla bug 1896167, which is invalid:

expected dependent Bugzilla bug 1892338 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-23T01:00:48Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-23T01:00:52Z

@openshift-bot: This pull request references Bugzilla bug 1896167, which is invalid:

expected dependent Bugzilla bug 1892338 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-24T01:00:48Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-24T01:00:52Z

@openshift-bot: This pull request references Bugzilla bug 1896167, which is invalid:

expected dependent Bugzilla bug 1892338 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-25T01:01:11Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-25T01:01:15Z

@openshift-bot: This pull request references Bugzilla bug 1896167, which is invalid:

expected dependent Bugzilla bug 1892338 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-26T01:01:18Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-26T01:01:21Z

@openshift-bot: This pull request references Bugzilla bug 1896167, which is invalid:

expected dependent Bugzilla bug 1892338 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-27T01:01:09Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-27T01:01:16Z

@openshift-bot: This pull request references Bugzilla bug 1896167, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1892338 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1892338 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-01-28T00:57:36Z

@openshift-cherrypick-robot: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift/cluster-ingress-operator#486 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1896167 has not been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot assigned sgreene570 Nov 9, 2020

openshift-cherrypick-robot mentioned this pull request Nov 9, 2020

Bug 1892338: metrics: Rework template_router_reload_failure metric #209

Merged

openshift-ci-robot requested review from danehans and ironcladlou November 9, 2020 21:15

openshift-ci-robot changed the title ~~[release-4.6] Bug 1892338: metrics: Rework template_router_reload_failure metric~~ [release-4.6] Bug 1896167: metrics: Rework template_router_reload_failure metric Nov 9, 2020

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Nov 9, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 9, 2020

openshift-ci-robot assigned Miciah Nov 12, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 12, 2020

Miciah mentioned this pull request Nov 12, 2020

[release-4.6] Bug 1896167: Back port HAProxy reload failures alert fix openshift/cluster-ingress-operator#486

Merged

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 27, 2020

jwforres added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 27, 2021

openshift-merge-robot merged commit 2f3e119 into openshift:release-4.6 Jan 28, 2021

[release-4.6] Bug 1896167: metrics: Rework template_router_reload_failure metric #215

[release-4.6] Bug 1896167: metrics: Rework template_router_reload_failure metric #215

Conversation

openshift-cherrypick-robot commented Nov 9, 2020

openshift-ci-robot commented Nov 9, 2020

openshift-ci-robot commented Nov 9, 2020

Miciah commented Nov 12, 2020

openshift-ci-robot commented Nov 12, 2020

openshift-bot commented Nov 12, 2020

openshift-bot commented Nov 12, 2020

openshift-bot commented Nov 13, 2020

openshift-ci-robot commented Nov 13, 2020

openshift-bot commented Nov 14, 2020

openshift-ci-robot commented Nov 14, 2020

openshift-bot commented Nov 15, 2020

openshift-ci-robot commented Nov 15, 2020

openshift-bot commented Nov 16, 2020

openshift-ci-robot commented Nov 16, 2020

openshift-bot commented Nov 17, 2020

openshift-ci-robot commented Nov 17, 2020

openshift-bot commented Nov 18, 2020

openshift-ci-robot commented Nov 18, 2020

openshift-bot commented Nov 19, 2020

openshift-ci-robot commented Nov 19, 2020

openshift-bot commented Nov 20, 2020

openshift-ci-robot commented Nov 20, 2020

openshift-bot commented Nov 21, 2020

openshift-ci-robot commented Nov 21, 2020

openshift-bot commented Nov 22, 2020

openshift-ci-robot commented Nov 22, 2020

openshift-bot commented Nov 23, 2020

openshift-ci-robot commented Nov 23, 2020

openshift-bot commented Nov 24, 2020

openshift-ci-robot commented Nov 24, 2020

openshift-bot commented Nov 25, 2020

openshift-ci-robot commented Nov 25, 2020

openshift-bot commented Nov 26, 2020

openshift-ci-robot commented Nov 26, 2020

openshift-bot commented Nov 27, 2020

openshift-ci-robot commented Nov 27, 2020

openshift-ci-robot commented Jan 28, 2021