Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template: Drop http-use-htx option #261

Merged

Conversation

sgreene570
Copy link

Commit 8580700 bumped the HAProxy version of the router
to v2.2. In HAProxy 2.2, the http-use-htx option is deprecated.

Commit da09224 added configurable HTTP header case names to the router.
With commits da09224 and 8580700 in place, we can safely remove the
http-use-htx option (and thus silence any HAProxy warnings about it's
deprecation).

Commit 8580700 bumped the HAProxy version of the router
to v2.2. In HAProxy 2.2, the `http-use-htx` option is deprecated.

Commit da09224 added configurable HTTP header case names to the router.
With commits da09224 and 8580700 in place, we can safely remove the
`http-use-htx` option (and thus silence any HAProxy warnings about it's
deprecation).
@sgreene570
Copy link
Author

This will resolve the following router pod log error in 4.8 nightlies:

I0219 17:25:18.023556       1 router.go:578] template "msg"="router reloaded"  "output"="[WARNING] 049/172517 (123) : parsing [/var/lib/haproxy/conf/haproxy.config:52]: option 'http-use-htx' is deprecated and ignored. The HTX mode is now the only supported mode.\n - Proxy protocol on, checking http://localhost:80 ...\n - Health check ok : 0 retry attempt(s).\n"

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2021
@frobware
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2021
@Miciah
Copy link
Contributor

Miciah commented Feb 19, 2021

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, Miciah, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Miciah,frobware,sgreene570]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 19, 2021

@sgreene570: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 0210d1e link /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3379121 into openshift:master Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants