-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
template: Drop http-use-htx option #261
template: Drop http-use-htx option #261
Conversation
Commit 8580700 bumped the HAProxy version of the router to v2.2. In HAProxy 2.2, the `http-use-htx` option is deprecated. Commit da09224 added configurable HTTP header case names to the router. With commits da09224 and 8580700 in place, we can safely remove the `http-use-htx` option (and thus silence any HAProxy warnings about it's deprecation).
This will resolve the following router pod log error in 4.8 nightlies:
|
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware, Miciah, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sgreene570: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Commit 8580700 bumped the HAProxy version of the router
to v2.2. In HAProxy 2.2, the
http-use-htx
option is deprecated.Commit da09224 added configurable HTTP header case names to the router.
With commits da09224 and 8580700 in place, we can safely remove the
http-use-htx
option (and thus silence any HAProxy warnings about it'sdeprecation).