Bug 1942534: [4.7 backport] Route gets admitted with invalid host name if override annotation is used

[candita]

The override added to address https://bugzilla.redhat.com/show_bug.cgi?id=1896977 was supposed to allow a route to be created, but not admitted, if it had an invalid host name. However, it allows the route to be admitted with an invalid host name. This fixes that.

[openshift-ci-robot]

@candita: This pull request references Bugzilla bug 1942534, which is invalid:

• expected the bug to target the "4.8.0" release, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1942534: [4.7 backport] Route gets admitted with invalid host name if override annotation is used

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@candita: This pull request references Bugzilla bug 1942534, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.z) matches configured target release for branch (4.7.z)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1925697 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 1925697 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
• bug has dependents

Requesting review from QA contact:
/cc @quarterpin

In response to this:

Bug 1942534: [4.7 backport] Route gets admitted with invalid host name if override annotation is used

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sgreene570]

@candita could you amend this PR's commit title to reflect the 4.7 bug number?

[candita]

@candita could you amend this PR's commit title to reflect the 4.7 bug number?

Done.

[sgreene570]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: candita, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [candita,sgreene570]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@candita: All pull requests linked via external trackers have merged:

• openshift/router#273

Bugzilla bug 1942534 has been moved to the MODIFIED state.

In response to this:

Bug 1942534: [4.7 backport] Route gets admitted with invalid host name if override annotation is used

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.