reload-haproxy: Use curl --haproxy-protocol #277
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
I tested the PR on AWS using cluster-bot ( Health checks in the router-default-6685855b9c-bvqfm and router-default-6685855b9c-xc75p pods show that the health check logic worked properly: |
|
However, the e2e-agnostic job shows incorrect behavior on GCP: the router-default-56f5697fc9-765t7 and router-default-56f5697fc9-mm8h4 pods logged the following: Looks like I used |
Miciah
force-pushed
the
reload-haproxy-use-curl-dash-dash-haproxy-dash-protocol
branch
from
eb212a1
to
620d3a2
Compare
openshift-ci-robot
added
the
needs-rebase
|
@Miciah: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This is terrific! Could we make the case to patch this as a bug? |
Use Curl's built-in support for PROXY protocol to replace the use of socat in the reload-haproxy script. The router image has included a version of Curl that supports PROXY protocol for a while now. * images/router/haproxy/reload-haproxy: Use curl --haproxy-protocol instead of socat when PROXY protocol is enabled.
Miciah
force-pushed
the
reload-haproxy-use-curl-dash-dash-haproxy-dash-protocol
branch
from
620d3a2
to
74864c4
Compare
openshift-ci
bot
removed
the
needs-rebase
|
Rebased. |
Possibly? This is more of a cleanup, but I'd be happy to get it in 4.8. |
|
/retest |
|
/test e2e-upgrade |
|
Nice! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Use Curl's built-in support for PROXY protocol to replace the use of socat in the reload-haproxy script. The router image has included a version of Curl that supports PROXY protocol for a while now.
images/router/haproxy/reload-haproxy: Use curl--haproxy-protocolinstead of socat when PROXY protocol is enabled.