Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: switch to haproxy24 RPM #313

Merged
merged 2 commits into from Jun 24, 2021
Merged

build: switch to haproxy24 RPM #313

merged 2 commits into from Jun 24, 2021

Conversation

frobware
Copy link
Contributor

Consume haproxy24 RPM.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2021
@frobware
Copy link
Contributor Author

/hold

This will fail until the haproxy24 brew build succeeds.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2021
@frobware
Copy link
Contributor Author

Currently waiting for a haproxy-2.4.1 build to turn up here: https://download.eng.bos.redhat.com/rcm-guest/puddles/RHAOS/plashets/4.9-el8/building/x86_64/os/Packages/?C=M;O=D

@frobware
Copy link
Contributor Author

/test images

2 similar comments
@frobware
Copy link
Contributor Author

/test images

@frobware
Copy link
Contributor Author

/test images

@frobware frobware mentioned this pull request Jun 23, 2021
Merged
@frobware
Copy link
Contributor Author

/test images

@frobware
Copy link
Contributor Author

/retest

@frobware
Copy link
Contributor Author

Removing the hold as my email says the haproxy22 package is no longer available.

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2021
@frobware
Copy link
Contributor Author

Link to thread regarding /test images build issues: https://coreos.slack.com/archives/CB95J6R4N/p1624470247047800

@frobware
Copy link
Contributor Author

Needs openshift/images#96 to merge first.

@Miciah
Copy link
Contributor

Miciah commented Jun 23, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@frobware
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jupierce
Copy link
Contributor

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9c39f58 into openshift:master Jun 24, 2021
This was referenced Jun 27, 2021
Closed
Closed
@frobware frobware mentioned this pull request Jul 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knobunc knobunc Awaiting requested review from knobunc

@sgreene570 sgreene570 Awaiting requested review from sgreene570

Assignees

@Miciah Miciah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@frobware @Miciah @openshift-bot @jupierce @openshift-merge-robot