Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.8] Bug 1990370: haproxy-config.template: Fix power-of-two balancing #324

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #323

/assign lihongan

Update the set of allowed balancing algorithms to include "random", i.e.,
the "Power of Two Random Choices" algorithm.  An earlier commit was
supposed to make "random" the default algorithm but failed to add it to the
set of allowed algorithms.  As a result, the template would configure
HAProxy to the "roundrobin" algorithm by default.  This commit makes it so
the effective default is "random", as intended in the earlier commit.

Follow-up to commit dbc994c.

This commit fixes bug 1988801.

https://bugzilla.redhat.com/show_bug.cgi?id=1988801

* images/router/haproxy/conf/haproxy-config.template: Fix
$balanceAlgoPattern to match "random".
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2021

@openshift-cherrypick-robot: Detected clone of Bugzilla bug 1988801 with correct target release. Retitling PR to link to clone:
/retitle [release-4.8] Bug 1990370: haproxy-config.template: Fix power-of-two balancing

In response to this:

[release-4.8] Bug 1988801: haproxy-config.template: Fix power-of-two balancing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.8] Bug 1988801: haproxy-config.template: Fix power-of-two balancing [release-4.8] Bug 1990370: haproxy-config.template: Fix power-of-two balancing Aug 5, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Aug 5, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1990370, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1988801 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1988801 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @quarterpin

In response to this:

[release-4.8] Bug 1990370: haproxy-config.template: Fix power-of-two balancing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 5, 2021
@openshift-ci openshift-ci bot requested a review from quarterpin August 5, 2021 09:48
@lihongan
Copy link
Contributor

lihongan commented Aug 5, 2021

/assign @Miciah

@lihongan lihongan removed their assignment Aug 5, 2021
@frobware
Copy link
Contributor

frobware commented Aug 5, 2021

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 5, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2021

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 5dc97a4 link /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@frobware
Copy link
Contributor

frobware commented Aug 5, 2021

/skip

@ecordell
Copy link

ecordell commented Aug 5, 2021

[patch-manager] 🚀 Approved for z-stream by score: 1.00

picked

@ecordell ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 5, 2021
@openshift-ci openshift-ci bot merged commit 9c9f9f4 into openshift:release-4.8 Aug 5, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1990370 has been moved to the MODIFIED state.

In response to this:

[release-4.8] Bug 1990370: haproxy-config.template: Fix power-of-two balancing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants