OCPBUGS-17653: haproxy/template: mitigate CVE-2023-40225

[frobware]

Mitigation rule taken from the HAProxy 2.6.15 release announcement:
https://www.mail-archive.com/haproxy@formilux.org/msg43864.html

And quoting from the release notes:

the check for invalid characters on content-length header values
doesn't reject empty headers, which can pass through. And since they
don't have a value, they're not merged with next ones, so it is
possible to pass a request that has both an empty content-length and
a populated one. Such requests are invalid and the vast majority of
servers will reject them. But there are certainly still a few
non-compliant servers that will only look at one of them,
considering the empty value equals zero and be fooled with this.
Thus the problem is not as much for mainstream users as for those
who develop their own HTTP stack or who purposely use haproxy to
protect a known-vulnerable server, because these ones may be at
risk. This issue was reported by Ben Kallus of Dartmouth College and
Narf Industries. A CVE was filed for this one. There is a
work-around, though: simply rejecting requests containing an empty
content-length header will do the job.

[openshift-ci-robot]

@frobware: This pull request references Jira Issue OCPBUGS-17653, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Mitigation rule taken from the HAProxy 2.6.15 release announcement:
https://www.mail-archive.com/haproxy@formilux.org/msg43864.html

And quoting from the release notes:

the check for invalid characters on content-length header values
doesn't reject empty headers, which can pass through. And since they
don't have a value, they're not merged with next ones, so it is
possible to pass a request that has both an empty content-length and
a populated one. Such requests are invalid and the vast majority of
servers will reject them. But there are certainly still a few
non-compliant servers that will only look at one of them,
considering the empty value equals zero and be fooled with this.
Thus the problem is not as much for mainstream users as for those
who develop their own HTTP stack or who purposely use haproxy to
protect a known-vulnerable server, because these ones may be at
risk. This issue was reported by Ben Kallus of Dartmouth College and
Narf Industries. A CVE was filed for this one. There is a
work-around, though: simply rejecting requests containing an empty
content-length header will do the job.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[frobware]

/assign @Miciah @gcs278

[Miciah]

Thanks!
/approve
/lgtm

/hold
for Grant's review.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Miciah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gcs278]

Looks good.
/lgtm
/hold cancel

[openshift-ci]

@frobware: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6	90966d7	link	false	/test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[Miciah]

/cherry-pick release-4.13

[openshift-ci-robot]

@frobware: Jira Issue OCPBUGS-17653: All pull requests linked via external trackers have merged:

• openshift/router#505

Jira Issue OCPBUGS-17653 has been moved to the MODIFIED state.

In response to this:

Mitigation rule taken from the HAProxy 2.6.15 release announcement:
https://www.mail-archive.com/haproxy@formilux.org/msg43864.html

And quoting from the release notes:

the check for invalid characters on content-length header values
doesn't reject empty headers, which can pass through. And since they
don't have a value, they're not merged with next ones, so it is
possible to pass a request that has both an empty content-length and
a populated one. Such requests are invalid and the vast majority of
servers will reject them. But there are certainly still a few
non-compliant servers that will only look at one of them,
considering the empty value equals zero and be fooled with this.
Thus the problem is not as much for mainstream users as for those
who develop their own HTTP stack or who purposely use haproxy to
protect a known-vulnerable server, because these ones may be at
risk. This issue was reported by Ben Kallus of Dartmouth College and
Narf Industries. A CVE was filed for this one. There is a
work-around, though: simply rejecting requests containing an empty
content-length header will do the job.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@Miciah: new pull request created: #506

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@Miciah: new pull request could not be created: failed to create pull request against openshift/router#release-4.13 from head openshift-cherrypick-robot:cherry-pick-505-to-release-4.13: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-505-to-release-4.13."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Miciah]

/cherry-pick release-4.12

[openshift-cherrypick-robot]

@Miciah: new pull request created: #507

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Miciah]

/cherry-pick release-4.11

[openshift-cherrypick-robot]

@Miciah: new pull request created: #509

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.