OCPBUGS-16707: UniqueHost: Fix incorrect identification of conflicting route

[frobware]

When a route is rejected due to the host already being claimed, it was
always selecting the first route but the first route is not guaranteed
to being the conflicting route.

All routes for the host are retrieved using the 'RoutesForHost'
function and that function returns a slice of routes derived from a
map in the 'hostIndex' structure. Since maps do not guarantee order,
the first route was not necessarily the oldest.

The fix is to first sort the conflicting routes based on their
submission time, and then pick the newest.

Fixes: https://issues.redhat.com/browse/OCPBUGS-16707

[openshift-ci-robot]

@frobware: This pull request references Jira Issue OCPBUGS-16707, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

When a route is rejected due to the host already being claimed, the
incorrect route was being identified as the conflicting one. The
problem was that the first route in the array was always being
returned as the conflicting route, instead of the actual conflicting
one.

This fix addresses the issue by returning the last route in the slice,
which corresponds to the correct conflicting route. This ensures that
the "HostAlreadyClaimed" error properly identifies the correct
conflicting route, taking into account both host and path.

Fixes: https://issues.redhat.com/browse/OCPBUGS-16707

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@frobware: This pull request references Jira Issue OCPBUGS-16707, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

When a route is rejected due to the host already being claimed, the
incorrect route was being identified as the conflicting one. The
problem was that the first route in the array was always being
returned as the conflicting route, instead of the actual conflicting
one.

Prior the this change routes were retrieved using the 'RoutesForHost'
function, which returns a slice of routes derived from a map in the
'hostIndex' structure. Since maps do not guarantee order, the first
route was not necessarily the oldest.

This fix addresses the issue by first sorting the conflicting routes
based on their submission time, and then picking the newest.

Fixes: https://issues.redhat.com/browse/OCPBUGS-16707

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@frobware: This pull request references Jira Issue OCPBUGS-16707, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

When a route is rejected due to the host already being claimed, it was
always selecting the first route but the first route is not guaranteed
to being the conflicting route.

All routes for the host are retrieved using the 'RoutesForHost'
function and that function returns a slice of routes derived from a
map in the 'hostIndex' structure. Since maps do not guarantee order,
the first route was not necessarily the oldest.

The fix is to first sort the conflicting routes based on their
submission time, and then pick the newest.

Fixes: https://issues.redhat.com/browse/OCPBUGS-16707

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[frobware]

Reproducer: https://github.com/frobware/haproxy-hacks/tree/master/OCPBUGS-16707

[frobware]

There are no nodes that your pod can schedule to - check your requests, tolerations, and node selectors (0/16 nodes are available

/test all

[candita]

/assign @rfredette

[frobware]

Too many days, ...
/retest

[rfredette]

I'm not entirely sure this fixes the issue. old here seems to be all the routes with the same host, but I think we also need to take path into account to decide which route conflicts. Sorting all the routes works for the reproducer script from your haproxy-hacks repo, but if I edit the script to create the routes in the order route2 > route1 > route3, then route3 reports that route1 is the conflicting route, even though it's actually route2 that's the problem:

route.route.openshift.io/route2 created
route.route.openshift.io/route1 created
route.route.openshift.io/route3 created
Name:                   route3
Namespace:              ocpbugs16707
Created:                3 seconds ago
Labels:                 <none>
Annotations:            <none>
Requested Host:         httpd-example-path-based-routes.apps.firstcluster.lab.upshift.rdu2.redhat.com
                        rejected by router default:  (host router-default.apps.ci-ln-xxi6972-72292.gcp-2.ci.openshift.org)HostAlreadyClaimed (3 seconds ago)
                          route route1 already exposes httpd-example-path-based-routes.apps.firstcluster.lab.upshift.rdu2.redhat.com and is older
Path:                   /api
TLS Termination:        <none>
Insecure Policy:        <none>
Endpoint Port:          http

Service:        api-service
Weight:         100 (100%)
Endpoints:      <error: endpoints "api-service" not found>

[frobware]

I pushed an update in ca357ed.

[rfredette]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfredette

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rfredette]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[frobware]

/jira refresh

[openshift-ci-robot]

@frobware: This pull request references Jira Issue OCPBUGS-16707, which is invalid:

• expected the bug to target the "4.15.0" version, but it targets "4.15" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[frobware]

/jira refresh

[openshift-ci-robot]

@frobware: This pull request references Jira Issue OCPBUGS-16707, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jitendar-singh

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[frobware]

/retest

[openshift-ci]

@frobware: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@frobware: Jira Issue OCPBUGS-16707: All pull requests linked via external trackers have merged:

• openshift/router#508

Jira Issue OCPBUGS-16707 has been moved to the MODIFIED state.

In response to this:

When a route is rejected due to the host already being claimed, it was
always selecting the first route but the first route is not guaranteed
to being the conflicting route.

All routes for the host are retrieved using the 'RoutesForHost'
function and that function returns a slice of routes derived from a
map in the 'hostIndex' structure. Since maps do not guarantee order,
the first route was not necessarily the oldest.

The fix is to first sort the conflicting routes based on their
submission time, and then pick the newest.

Fixes: https://issues.redhat.com/browse/OCPBUGS-16707

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-merge-robot]

Fix included in accepted release 4.15.0-0.nightly-2023-09-27-073353