Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: hack - fix broken RPM link and use UBI image in Dockerfile.debug, use podman in Makefile.debug #544

Merged
merged 1 commit into from Dec 21, 2023
Merged

NO-JIRA: hack - fix broken RPM link and use UBI image in Dockerfile.debug, use podman in Makefile.debug #544

merged 1 commit into from Dec 21, 2023
+6 −5

Conversation

alebedev87
Copy link
Contributor

@alebedev87 alebedev87 commented Dec 1, 2023 •
edited

The PR aims at fixing the broken RPM link in hack/Dockerfile.debug as well as bring a better building experience by:

  • migrating the base image to the universal one
  • using podman as the image builder

@alebedev87 alebedev87 mentioned this pull request Dec 1, 2023
Open
@alebedev87
Copy link
Contributor Author

/test e2e-aws-serial
/test e2e-metal-ipi-ovn-ipv6

@philipgough philipgough mentioned this pull request Dec 4, 2023
Closed
@alebedev87
Copy link
Contributor Author

/test e2e-metal-ipi-ovn-ipv6

@alebedev87 alebedev87 changed the title hack: use UBI image in Dockerfile.debug, use podman in Makefile.debug hack: fix broken RPM link, use UBI image in Dockerfile.debug, use podman in Makefile.debug Dec 5, 2023
@alebedev87 alebedev87 changed the title hack: fix broken RPM link, use UBI image in Dockerfile.debug, use podman in Makefile.debug hack: fix broken RPM link and use UBI image in Dockerfile.debug, use podman in Makefile.debug Dec 5, 2023
@candita
Copy link
Contributor

candita commented Dec 20, 2023

/assign @gcs278

@gcs278
Copy link
Contributor

gcs278 commented Dec 20, 2023

Tried it out, worked for me. It's a hack repo, so no risk to the product.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gcs278

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2023
@alebedev87 alebedev87 changed the title hack: fix broken RPM link and use UBI image in Dockerfile.debug, use podman in Makefile.debug NO-JIRA: hack - fix broken RPM link and use UBI image in Dockerfile.debug, use podman in Makefile.debug Dec 21, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 21, 2023
@openshift-ci-robot
Copy link
Contributor

@alebedev87: This pull request explicitly references no jira issue.

In response to this:

The PR aims at fixing the broken RPM link in hack/Dockerfile.debug as well as bring a better building experience by:

  • migrating the base image to the universal one
  • using podman as the image builder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c386478 and 2 for PR HEAD 5a7f745 in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2023
@alebedev87
Copy link
Contributor Author

Rebased from master to fix the unit test.

@alebedev87
Copy link
Contributor Author

/retest-required

@alebedev87
Copy link
Contributor Author

/test e2e-upgrade

@gcs278
Copy link
Contributor

gcs278 commented Dec 21, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2023
@alebedev87
Copy link
Contributor Author

/test e2e-upgrade

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c386478 and 2 for PR HEAD 9a72cd6 in total

@alebedev87
Copy link
Contributor Author

/test e2e-upgrade

@alebedev87
Copy link
Contributor Author

/override e2e-upgrade

The PR changes debug file and cannot impact any test.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 21, 2023

@alebedev87: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-upgrade

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-agnostic
  • ci/prow/e2e-aws-serial
  • ci/prow/e2e-metal-ipi-ovn-ipv6
  • ci/prow/e2e-upgrade
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • pull-ci-openshift-router-master-e2e-agnostic
  • pull-ci-openshift-router-master-e2e-aws-serial
  • pull-ci-openshift-router-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-router-master-e2e-upgrade
  • pull-ci-openshift-router-master-images
  • pull-ci-openshift-router-master-unit
  • pull-ci-openshift-router-master-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override e2e-upgrade

The PR changes debug file and cannot impact any test.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alebedev87
Copy link
Contributor Author

/override ci/prow/e2e-upgrade

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 21, 2023

@alebedev87: Overrode contexts on behalf of alebedev87: ci/prow/e2e-upgrade

In response to this:

/override ci/prow/e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 21, 2023

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 00f1690 into openshift:master Dec 21, 2023
8 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-haproxy-router-base-container-v4.16.0-202312212331.p0.g00f1690.assembly.stream for distgit ose-haproxy-router-base.
All builds following this will include this PR.

@frobware frobware mentioned this pull request Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@candita candita Awaiting requested review from candita

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@gcs278 gcs278

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alebedev87 @candita @gcs278 @openshift-ci-robot @openshift-bot