Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NE-1446: Update to RHEL9 base image #548

Merged
merged 1 commit into from Dec 20, 2023
Merged

NE-1446: Update to RHEL9 base image #548

merged 1 commit into from Dec 20, 2023

Conversation

gcs278
Copy link
Contributor

@gcs278 gcs278 commented Dec 11, 2023 •
edited by openshift-ci bot

Update the base image for the router from RHEL8 to RHEL9.

.ci-operator.yaml: Update ci-operator build_root imagestream
images/router/base/Dockerfile.rhel: Update builder and router image

Perf & Scale run documented in NE-1448

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2023
@gcs278 gcs278 mentioned this pull request Dec 11, 2023
Closed
@gcs278
Copy link
Contributor Author

gcs278 commented Dec 11, 2023

/test perfscale-aws-fips-ingress-perf

@gcs278
Copy link
Contributor Author

gcs278 commented Dec 11, 2023

/test perfscale-aws-ingress-perf

@jtaleric
Copy link

/test perfscale-aws-ingress-perf perfscale-aws-fips-ingress-perf

2 similar comments
@jtaleric
Copy link

/test perfscale-aws-ingress-perf perfscale-aws-fips-ingress-perf

@rsevilla87
Copy link
Member

/test perfscale-aws-ingress-perf perfscale-aws-fips-ingress-perf

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2023
@rsevilla87
Copy link
Member

/test perfscale-aws-ingress-perf perfscale-aws-fips-ingress-perf

@gcs278
Copy link
Contributor Author

gcs278 commented Dec 18, 2023

There was an issue with alibaba-cloud-controller-manager image, unrelated to this.

/test e2e-aws-serial
/test e2e-upgrade
/test perfscale-aws-ingress-perf perfscale-aws-fips-ingress-perf

@gcs278
NE-1446: Update to RHEL9 base image
325fe48 
Update the base image for the router from RHEL8 to RHEL9.

`.ci-operator.yaml`: Update ci-operator build_root imagestream
`images/router/base/Dockerfile.rhel`: Update builder and router
image
@gcs278 gcs278 changed the title WIP: DO NOT MERGE: RHEL 9 smoke test NE-1446: Update to RHEL9 base image Dec 20, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 20, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 20, 2023 •
edited by openshift-ci bot

@gcs278: This pull request references NE-1446 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Adapted from #538 because I couldn't update @frobware's repo and I needed to update to 4.16 base images.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 20, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 20, 2023 •
edited by openshift-ci bot

@gcs278: This pull request references NE-1446 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Update the base image for the router from RHEL8 to RHEL9.

.ci-operator.yaml: Update ci-operator build_root imagestream
images/router/base/Dockerfile.rhel: Update builder and router image

Perf & Scale run documented in https://issues.redhat.com/browse/NE-1448

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 20, 2023 •
edited by openshift-ci bot

@gcs278: This pull request references NE-1446 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Update the base image for the router from RHEL8 to RHEL9.

.ci-operator.yaml: Update ci-operator build_root imagestream
images/router/base/Dockerfile.rhel: Update builder and router image

Perf & Scale run documented in NE-1448

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 20, 2023 •
edited by openshift-ci bot

@gcs278: This pull request references NE-1446 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Update the base image for the router from RHEL8 to RHEL9.

.ci-operator.yaml: Update ci-operator build_root imagestream
images/router/base/Dockerfile.rhel: Update builder and router image

Perf & Scale run documented in NE-1448

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah
Copy link
Contributor

Miciah commented Dec 20, 2023

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2023
@candita
Copy link
Contributor

candita commented Dec 20, 2023

/lgtm

Work later on what happens with rebase for #550

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2dd4c02 and 2 for PR HEAD 325fe48 in total

@gcs278
Copy link
Contributor Author

gcs278 commented Dec 20, 2023

/hold
Give the ART Team some time to review before merging. I'll remove the hold at the end of the day.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2023
@thegreyd thegreyd mentioned this pull request Dec 20, 2023
Merged
@gcs278
Copy link
Contributor Author

gcs278 commented Dec 20, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2023
@gcs278
Copy link
Contributor Author

gcs278 commented Dec 20, 2023

Failures regarding machine-config and Prometheus don't seem related
/test e2e-upgrade

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 20, 2023

@gcs278: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 325fe48 link false /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4e0f5aa into openshift:master Dec 20, 2023
7 of 8 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-haproxy-router-base-container-v4.16.0-202312210011.p0.g4e0f5aa.assembly.stream for distgit ose-haproxy-router-base.
All builds following this will include this PR.

@Miciah Miciah mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@candita candita Awaiting requested review from candita

@Miciah Miciah Awaiting requested review from Miciah

Assignees

@candita candita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@gcs278 @jtaleric @rsevilla87 @openshift-ci-robot @Miciah @candita @openshift-bot @openshift-merge-robot