NE-1444: switch container builds to haproxy28 #556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
frobware
commented
Jan 12, 2024
•
frobware
commented
- haproxy/template: Explicitly enable ALPN for HTTP/2 on SSL listeners
- NE-1444: container builds: switch to haproxy28 RPM package
This commit introduces explicit ALPN configuration for ingress controllers with HTTP/2 enabled, focusing on the public fe_sni and public fe_no_sni listeners. In HAProxy 2.8.0[1], a significant change was noted: "HTTP/2 is now advertised by default in ALPN on TLS listeners. This marks a pivotal change, as HTTP/2 has been available for 5 years and enabled by default in clear text as an HTTP/1 upgrade for 4 years. However, some users were still unaware of how to enable it. Now, ALPN will default to 'h2,http/1.1' on TCP and 'h3' on QUIC, ensuring these protocol versions work by default. Adjustments to ALPN settings remain possible to enable or disable these protocols. Furthermore, previous concerns regarding window sizes have been resolved by introducing distinct settings for each side (front vs back)." In anticipation of transitioning to HAProxy 2.8 and to align with its defaults, this commit proactively adds "alpn h2,http/1.1" to the fe_sni and fe_no_sni listeners whenever HTTP/2 is enabled. And, importantly, this change also allows us to address two long-standing test skips in openshift/origin (test/extended/router/http2). Even without moving to HAProxy 2.8, this change enables us to resolve these testing issues, enhancing the reliability and coverage of our test suite for both HAProxy 2.6 and HAProxy 2.8. [1] https://www.mail-archive.com/haproxy@formilux.org/msg43600.html
frobware
changed the title
|
@frobware: This pull request references NE-1444 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.