OCPBUGS-32044: Introduce 'idle-close-on-response' option for frontends #573
Conversation
openshift-ci-robot
added
jira/severity-critical
|
@alebedev87: This pull request references Jira Issue OCPBUGS-32044, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-serial |
|
@alebedev87: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-serial |
|
@alebedev87: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ec907a70-fb24-11ee-9600-fee9bca1e7a1-0 |
| # https://issues.redhat.com/browse/OCPBUGS-32044 | ||
| option idle-close-on-response |
There was a problem hiding this comment.
If you provide a bare URL or bug number with no further information, then the reader has to look up the bug report. If the reader has to do a lookup, then the reader could just as easily use git-blame to look up the commit message, which should explain the change and have a reference to the bug report. Could you add more details to the comment, or just remove the comment entirely and rely on the commit message to explain the change?
| # https://issues.redhat.com/browse/OCPBUGS-32044 | |
| option idle-close-on-response | |
| # Work around an issue with Apache HttpClient 4.5's connection pooling manager, | |
| # which may attempt to re-use closed idle connections if this option is not enabled. | |
| option idle-close-on-response |
There was a problem hiding this comment.
I didn't give this diff enough of care yet. I just dropped the option to be able to test it. If this change will be the way to go I think I'll add some text as you proposed.
Btw the issue is not only with the Apache HTTP Client, initially the option was implemented for AWS because the ALBs kept sending requests to the closed (idle before) connections (haproxy/haproxy#1506).
There was a problem hiding this comment.
The comments and the commit message are updated. PTAL.
alebedev87
force-pushed
the
idle-close-on-reponse
branch
from
802029b
to
96e85c7
Compare
alebedev87
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@alebedev87: This pull request references Jira Issue OCPBUGS-32044, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Not sure the verbiage associated with the option needs repeating 3 times. /lgtm |
This committ addresses a known issue (OCPBUGS-32044) encountered with certain HTTP clients, notably the Apache HTTP client (prior to version 5), where closed idle connections are erroneously reused. To mitigate this, we introduce the 'idle-close-on-response' option, which is now applied to all frontends operating in HTTP mode. Note that the 'public_ssl' frontend remains in TCP mode and is unaffected by this change.
alebedev87
force-pushed
the
idle-close-on-reponse
branch
from
96e85c7
to
7df65af
Compare
|
Redundant comments about the option are removed. |
|
/lgtm |
|
Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@alebedev87: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@alebedev87: Jira Issue OCPBUGS-32044: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-32044 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.15 |
|
@alebedev87: new pull request created: #579 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.14 |
|
@alebedev87: new pull request created: #580 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-haproxy-router-base-container-v4.16.0-202404181812.p0.ga14aea7.assembly.stream.el9 for distgit ose-haproxy-router-base. |
This PR addresses a known issue (OCPBUGS-32044) encountered with certain HTTP clients, notably the Apache HTTP client (prior to version 5), where closed idle connections are erroneously reused. To mitigate this, we introduce the
idle-close-on-responseoption, which is now applied to all frontends operating in HTTP mode. Note that thepublic_sslfrontend remains in TCP mode and is unaffected by this change.Spin off of #572.