Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] OCPBUGS-32693: Reject routes with MD5 certs #584

Merged
merged 1 commit into from
May 6, 2024
Merged

[release-4.15] OCPBUGS-32693: Reject routes with MD5 certs #584

merged 1 commit into from
May 6, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #553

/assign gcs278

@gcs278
OCPBUGS-26539: Reject routes with MD5 certs
9fdfb8b 
Add logic to the extended route validation to reject any MD5-based
certs.

`pkg/router/routeapihelpers/validation.go`: Add logic to
validateCertificatePEM to reject certs with MD5
`pkg/router/routeapihelpers/validation_test.go`: Add unit test case for
validating route with cert using MD5
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 23, 2024
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-26539 has been cloned as Jira Issue OCPBUGS-32693. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-32693: Reject routes with MD5 certs

In response to this:

This is an automated cherry-pick of #553

/assign gcs278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-26539: Reject routes with MD5 certs [release-4.15] OCPBUGS-32693: Reject routes with MD5 certs Apr 23, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 23, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-32693, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #553

/assign gcs278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gcs278 gcs278 mentioned this pull request Apr 23, 2024
Open
@Miciah
Copy link
Contributor

Miciah commented Apr 23, 2024

Quoting Grant:

it's low risk as the HaProxy currently fails to start when it tries to process a spec.tls.certificate with an MD5 cert (same type of issues as SHA1 in 4.16).

Moreover, the change is a small change, well isolated in the extended validation logic, and conditioned on certificates that use the MD5 signature algorithm. All in all, I agree that this backport is low risk.

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 23, 2024
@Miciah
Copy link
Contributor

Miciah commented Apr 23, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2024
@gcs278
Copy link
Contributor

gcs278 commented Apr 23, 2024

/refresh jira

@gcs278
Copy link
Contributor

gcs278 commented Apr 23, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 23, 2024
@openshift-ci-robot
Copy link
Contributor

@gcs278: This pull request references Jira Issue OCPBUGS-32693, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-26539 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-26539 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @lihongan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from lihongan April 23, 2024 03:23
@gcs278
Copy link
Contributor

gcs278 commented Apr 23, 2024

OVNKubernetesResourceRetryFailure. Doesn't appear related.
/test e2e-aws-serial

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 23, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ShudiLi
Copy link
Member

ShudiLi commented May 6, 2024

/label cherry-pick-approved
thanks

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1cac6b7 into openshift:release-4.15 May 6, 2024
8 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-32693: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32693 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #553

/assign gcs278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-haproxy-router-base-container-v4.15.0-202405060208.p0.g1cac6b7.assembly.stream.el8 for distgit ose-haproxy-router-base.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-05-06-031252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lihongan lihongan Awaiting requested review from lihongan

Assignees

@Miciah Miciah

@gcs278 gcs278

@lihongan lihongan

@melvinjoseph86 melvinjoseph86

@ShudiLi ShudiLi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@openshift-cherrypick-robot @openshift-ci-robot @Miciah @gcs278 @ShudiLi @openshift-bot @openshift-merge-robot @lihongan @melvinjoseph86