Bug 1780794: unique_host: HandleRoute: No error if host claimed #69
Conversation
Change the unique_host plugin's HandleRoute method not to return an error
because the host name is claimed.
Returning an error causes the controller to log an unhelpful error message:
router_controller.go:244] another route has claimed this host
The plugin already logs the conflict, along with the host name and the
claimants' names and namespaces, at a higher log level and updates the
Route's status to indicate that it has been rejected because of a
preëmpting claim. Moreover, a conflicting claim does not logically
represent an error condition for the plugin or controller, and in the
absence of such, it makes more sense return a nil error value after logging
the condition.
This commit fixes bug 1780794.
https://bugzilla.redhat.com/show_bug.cgi?id=1780794
* pkg/router/controller/unique_host.go: Do not return a gratuitous error
value for a preëmpting claim.
* pkg/router/template/plugin_test.go (TestHandleRoute): Expect a nil error
value from the unique_host plugin when handling a valid Route for which a
preëmpting claim exists.
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@Miciah: This pull request references Bugzilla bug 1780794, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/S
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Miciah: All pull requests linked via external trackers have merged. Bugzilla bug 1780794 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Change the unique_host plugin's
HandleRoutemethod not to return an error because the host name is claimed.Returning an error causes the controller to log an unhelpful error message:
The plugin already logs the conflict, along with the host name and the claimants' names and namespaces, at a higher log level and updates the Route's status to indicate that it has been rejected because of a preëmpting claim. Moreover, a conflicting claim does not logically represent an error condition for the plugin or controller, and in the absence of such, it makes more sense return a nil error value after logging the condition.
pkg/router/controller/unique_host.go: Do not return a gratuitous error value for a preëmpting claim.pkg/router/template/plugin_test.go(TestHandleRoute): Expect a nil error value from the unique_host plugin when handling a valid Route for which a preëmpting claim exists.