Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help update Dockerfile to adjust docker build with ruby-25-rhel7 image #80

Closed
xiuwang opened this issue Jul 24, 2019 · 7 comments
Closed
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@xiuwang
Copy link

xiuwang commented Jul 24, 2019

Hi, anyone could help update Dockerfile to adjust docker build with ruby-25-rhel7?
Since from 4.2, the openshift/ruby:2.2 imagestreamtag is end of life in openshift cluster.
Thanks~

@xiuwang xiuwang changed the title Help update Dockerfile to adjust ruby-25-rhel7 Help update Dockerfile to adjust docker build with ruby-25-rhel7 image Jul 24, 2019
@wewang58
Copy link
Contributor

@adambkaplan @gabemontero @coreydaley anyone takes time to update this to be compatible with ruby 2.5, now our qe ci automation failed of this, though I saw it's in todo e2e list: https://github.com/openshift/origin/blob/master/test/extended/builds/start.go#L284, thanks very much.

@adambkaplan
Copy link

@wewang58 you can probably give this a shot yourselves, we'd be happy to review a PR.

What you'll need to do is as follows:

  1. Switch the Dockerfile to use the ruby-25-centos7 image
  2. On a machine or container with ruby 2.5, update the Gemfile to use compatible versions of the gems. Run bundle install and commit the resulting Gemfile and Gemfile.lock files.
  3. Submit a PR with the results.

@pvalena
Copy link
Contributor

pvalena commented Nov 27, 2019

Implemented in #85 AFAICT.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 22, 2020
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 23, 2020
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

6 participants