Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-18340: Update runbooks for ovn-ic #136

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bpickard22
Copy link
Contributor

remove runbooks for alerts no longer reported with implementation of ovn-ic and ubdate runbooks related to alerts still reported to be up to date with ovn-ic

@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 13, 2023
@openshift-ci-robot
Copy link

@bpickard22: This pull request references Jira Issue OCPBUGS-18340, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

remove runbooks for alerts no longer reported with implementation of ovn-ic and ubdate runbooks related to alerts still reported to be up to date with ovn-ic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bpickard22
Once this PR has been reviewed and has the lgtm label, please assign nautilux for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@martinkennelly
Copy link
Contributor

/assign @martinkennelly
Can you fix the markdown lint?

@martinkennelly
Copy link
Contributor

@bpickard22 After a quick look, it looks like you arent considering for versioning - unfortunately, this repo doesnt have versioning so you must include 4.13 and below and 4.14 and above :(

@martinkennelly
Copy link
Contributor

Ill take a look again when youve updated the runbooks with versioning and also passing the lint.

@martinkennelly
Copy link
Contributor

Any questions - DM me or ask here.

remove runbooks for alerts no longer reported with implementation of
ovn-ic and ubdate runbooks related to alerts still reported to be up to
date with ovn-ic

Signed-off-by: Ben Pickard <bpickard@redhat.com>
@bpickard22
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 21, 2023
@openshift-ci-robot
Copy link

@bpickard22: This pull request references Jira Issue OCPBUGS-18340, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Add a legacy section to runbooks with info needed for pre-ic clusters

Signed-off-by: Ben Pickard <bpickard@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2023

@bpickard22: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@martinkennelly martinkennelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first pass


### If one of the ovnkube-control-plane pods is not running

The ovnkube-cluster-manager container in the ovn kubernetes control-plane pod
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems more like diagnosis than mitigation. I think in this mitigation, we should list a few error scenarios and then what to do for each scenario. Users can get why the leader election failed from the logs in the steps in diagnosis.

  1. Leader election failed because of timeout
    In this scenario, we wanted to check 2 things: if the API server is overloaded and if CM can reach the API server. If its overloaded, reduce load on API server. If its not overloaded, check connection between node and api server endpoints.
  2. Leader election failed because of connection refused
    In this scenario, API server is not serving at the specific ip + port. Restore api server functionality.

We can add more when more scenarios arise.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe search for more scenarios why leader election failed in the past for some examples.


oc logs -n openshift-ovn-kubernetes ovnkube-control-plane-xxxxx --all-containers | grep elect

## Mitigation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think overall in this section, we should list some scenarios found in the previous sections diagnoses and offer some actions. We dont need to get into nodes not Ready, or the pod not ready i think. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i think that makes sense lets go with that

[Running][PodRunning]
This is a critical-level alert if no OVN-Kubernetes master control plane pods
This is a critical-level alert if no OVN-Kubernetes control plane pods
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In impact section, i think put in the services that may not be working. i listed them in a previous comment.


`holder` shown above, contains the node name where the leader pod
resides.
Check the logs for any of the running ovnkube-control-plane to see if there is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think just stick with the one found in the lease - IF there is even one set there.
also any of the running ovnkube-control-plane pods

`holder` shown above, contains the node name where the leader pod
resides.
Check the logs for any of the running ovnkube-control-plane to see if there is
leader election happened and if there is an error occurred.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is bad english - rephase.


### If all the ovnkube-control-plane pods are not running

Check the status of the ovnkube-control-plane pods, and follow the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id remove this. Cluster admins or SREs understand this pod lifecycle.


### If all the ovnkube-control-plane pods are running

Follow the steps above: [OVN-Kubernetes master pods](#ovn-kubernetes-control-plane-pods)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

control plane pods


## Mitigation

### If the control plane nodes are not running
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you want to follow the disaster and recovery doc here? I looked at the criteria for it and i dont know if CM not being able to become a leader warrants using this doc.

@tssurya
Copy link

tssurya commented Jan 29, 2024

@bpickard22 : PTAL, bug is open too long

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 29, 2024
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 29, 2024
@martinkennelly
Copy link
Contributor

/remove-lifecycle rotten

@openshift-ci openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 29, 2024
@martinkennelly
Copy link
Contributor

Ben, we should proceed on this. Let me know when youre ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants