Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.1 deployment instructions is pointing to wrong links #158

Closed
fidencio opened this issue Nov 30, 2021 · 2 comments
Closed

release-1.1 deployment instructions is pointing to wrong links #158

fidencio opened this issue Nov 30, 2021 · 2 comments

Comments

@fidencio
Copy link
Contributor

Description

https://github.com/openshift/sandboxed-containers-operator/tree/release-1.1#without-a-git-repo-checkout points to a non-existent file.

The document mentions:

To deploy the operator and create a custom resource (which installs Kata on all worker nodes), run curl https://raw.githubusercontent.com/openshift/sandboxed-containers-operator/master/deploy/install.sh | bash

However, https://raw.githubusercontent.com/openshift/sandboxed-containers-operator/master/deploy/install.sh is a non-existent file.
Most likely it should point to https://raw.githubusercontent.com/openshift/sandboxed-containers-operator/release-1.1/deploy/install.sh

Steps to reproduce the issue:

  1. Open your web browser
  2. Go to https://github.com/openshift/sandboxed-containers-operator/tree/release-1.1#without-a-git-repo-checkout
  3. Try to follow the instructions provided

Describe the results you received:

[fidencio@kundera ocp]$ curl https://raw.githubusercontent.com/openshift/sandboxed-containers-operator/master/deploy/install.sh | bash
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    14  100    14    0     0     57      0 --:--:-- --:--:-- --:--:--    57
bash: line 1: 404:: command not found

Describe the results you expected:

The deployment would start.

Additional information you deem important (e.g. issue happens only occasionally):

Not relevant

Output of oc describe kataconfig <your-kataconfig>:

Not relevant

Additional environment details (platform, options, etc.):

Not relevant

@fidencio
Copy link
Contributor Author

Note that the script itself also has to be updated to point to the release branch.

@bpradipt
Copy link
Contributor

bpradipt commented Dec 1, 2021

Fixed via #160

@bpradipt bpradipt closed this as completed Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants