Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for 1.1 release #160

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Conversation

bpradipt
Copy link
Contributor

@bpradipt bpradipt commented Dec 1, 2021

- Description of the problem which is fixed/What is the use case
The README was dated containing incorrect installation instructions.
Fixes: #156, #157 , #158 , #159

- What I did
Added instructions to deploy 1.1 on OpenShift 4.9

- How to verify it
By following the instructions to deploy the operator

- Description for the changelog

Fix deployment instructions for release-1.1 on OCP4.9

@openshift-ci openshift-ci bot requested review from harche and jensfr December 1, 2021 07:14
@bpradipt
Copy link
Contributor Author

bpradipt commented Dec 1, 2021

@Fidenco kindly check the updated deployment instructions and let me know.

@fidencio
Copy link
Contributor

fidencio commented Dec 1, 2021

LGTM, @bpradipt. Although I don't think it actually fixes one of problems I hit as part of #159, which you may prefer treating it in a different issue (see: #159 (comment))

Last but not least, the README from the master branch is still wrong, so I don't think #156 should be closed, but rather have the main branch updated to point to the release-1.1 if folks are using the OCP 4.9.

@bpradipt
Copy link
Contributor Author

bpradipt commented Dec 1, 2021

LGTM, @bpradipt. Although I don't think it actually fixes one of problems I hit as part of #159, which you may prefer treating it in a different issue (see: #159 (comment))

Last but not least, the README from the master branch is still wrong, so I don't think #156 should be closed, but rather have the main branch updated to point to the release-1.1 if folks are using the OCP 4.9.

Right, for 156 will send a new PR against the main branch.

@bpradipt bpradipt merged commit 2859f88 into openshift:release-1.1 Dec 1, 2021
@bpradipt bpradipt deleted the 1.1-deploy branch December 1, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants