Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build artifacts to .gitignore #208

Closed
cpmeadors opened this issue Aug 15, 2022 · 3 comments
Closed

Add build artifacts to .gitignore #208

cpmeadors opened this issue Aug 15, 2022 · 3 comments

Comments

@cpmeadors
Copy link
Contributor

cpmeadors commented Aug 15, 2022

I see these new or modified files when I run make docker-build, bundle-build, and catalog-build. They should be added to the .gitignore file so they don't accidentally get checked in.

Untracked files:
bin/controller-gen
bin/setup-envtest
bin/kustomize
bin/opm

@bpradipt
Copy link
Contributor

Yes. bin folder should be added to .gitignore. Also there are some tmp directories created during make bundle eg bundle_tmp*. This should be added also imho.

@cpmeadors would you mind sending a PR to fix this?

@cpmeadors
Copy link
Contributor Author

cpmeadors commented Aug 26, 2022 via email

@cpmeadors
Copy link
Contributor Author

cpmeadors commented Oct 24, 2022

Fixed as part of #219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants