-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch Series to handle upgrading to latest version of operator-sdk #134
Conversation
Seems the CI is failing due to change of operator name (OO_PACKAGE) |
/retest |
I won't pretend I'm able to review properly all of this :-) so I'll have just two questions:
Thanks! |
/retest |
7b97c33
to
3f30c8a
Compare
/retest |
3 similar comments
/retest |
/retest |
/retest |
6889623
to
72262c5
Compare
/retest |
/hold |
1d8adb4
to
11c416b
Compare
11c416b
to
35cbf0b
Compare
Installing
I tested webhook on a real cluster and it prevents multiple KataConfig from being created. I would also suspect that any issues will get covered in unit tests itself as we do have webhook based tests.
|
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you @bpradipt !
- Description of the problem which is fixed/What is the use case
This patch series makes necessary changes to the code base to align with latest operator-sdk (v1.11.0) , controller-runtime (0.9.2) and kubernetes version (1.21.2)
- What I did
Updated code, dependencies etc
- How to verify it
Building and installing the cluster by following the developer documentation
- Description for the changelog
Upgrade to handle latest operator-sdk (v1.11.0) , controller-runtime (0.9.2) and kubernetes version (1.21.2)