Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description of CheckNodeEligibility option #169

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

bpradipt
Copy link
Contributor

- Description of the problem which is fixed/What is the use case
The current description of the "CheckNodeEligibility" option that is displayed when creating KataConfig via OpenShift UI is misleading.
- What I did
Updated the description to closely aligned with the implementation
- How to verify it
When creating the KataConfig instance, check the description of the "CheckNodeEligibility" option and you should see the following:

"CheckNodeEligibility is used to detect the node(s) eligibility to run Kata containers. 
This is currently done through the use of the Node Feature Discovery Operator (NFD). 
For more information on how the check works, please refer to the sandboxed containers documentation - https://docs.openshift.com/container-platform/latest/sandboxed_containers/deploying-sandboxed-container-workloads.html"

- Description for the changelog
Fix "CheckNodeEligibility" description.

@bpradipt bpradipt requested a review from jensfr January 19, 2022 11:19
@openshift-ci openshift-ci bot requested a review from pmores January 19, 2022 11:19
@openshift-ci
Copy link

openshift-ci bot commented Jan 19, 2022

@bpradipt: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@jensfr jensfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you @bpradipt

@bpradipt bpradipt merged commit e403a36 into openshift:master Jan 19, 2022
@bpradipt bpradipt deleted the eligibility-desc branch January 19, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants