KATA-1444: remove nodeSelector from controller deployment #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we restrict the operator to run on master nodes only. However, there is no technical reason for this setting. It creates a problem when a cluster-admin sets the defaultNodeScheduler field to schedule everything to workers. In that case our controller could not be placed anywhere by the scheduler and would get stuck in 'Pending' state. By removing the nodeSelector field from our controller manifest we let the scheduler place the controller pod also on worker nodes so that we don't get into the above described situation anymore. I tested this on clusters with - three control-plane and three worker nodes - a converged cluster where control-plane and worker nodes are on the same machines - a single-node cluster and did not run into problems. The test procedure included deploying a cluster, creating a kataconfig CR, running a workload with kata runtime class, deleting the kataconfig CR and destroying the cluster. Signed-off-by: Jens Freimann <jfreimann@redhat.com>
jensfr
changed the title
bpradipt
approved these changes
Mar 28, 2022
|
@jensfr: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@jensfr closing and re-opening the PR did the trick and the tests ran successfully. Merging this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we restrict the operator to run on master nodes only.
However, there is no technical reason for this setting. It
creates a problem when a cluster-admin sets the defaultNodeScheduler
field to schedule everything to workers. In that case our controller
could not be placed anywhere by the scheduler and would get stuck
in 'Pending' state.
By removing the nodeSelector field from our controller manifest we let
the scheduler place the controller pod also on worker nodes so that we
don't get into the above described situation anymore.
I tested this on clusters with
same machines
and did not run into problems. The test procedure included deploying a
cluster, creating a kataconfig CR, running a workload with kata runtime
class, deleting the kataconfig CR and destroying the cluster.
Signed-off-by: Jens Freimann jfreimann@redhat.com