-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KATA-1437: update version numbers in config, Makefile and README #186
Conversation
/retest |
@@ -73,7 +73,7 @@ spec: | |||
|
|||
On the Install Operator page: | |||
|
|||
- Select `stable-1.2` from the list of available Update Channel options. | |||
- Select `stable-1.3` from the list of available Update Channel options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For upstream master/main branch we are using candidate
channel. For downstream (from release branches) we'll be using stable-1.x
channel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed it to say use candidate
for latest and stable-x.y
for already release versions
Makefile
Outdated
@@ -3,7 +3,7 @@ | |||
# To re-generate a bundle for another specific version without changing the standard setup, you can: | |||
# - use the VERSION as arg of the bundle target (e.g make bundle VERSION=0.0.2) | |||
# - use environment variables to overwrite this value (e.g export VERSION=0.0.2) | |||
VERSION ?= 1.2.0 | |||
VERSION ?= 1.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try with latest
version? I'm thinking if we can switch to latest for main/master branch and set the sem version string for release branches.
The test failed due to lack of resources. Restarting |
@bpradipt: The
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test 4.9-sandboxed-containers-operator-e2e |
This patch increases the version number from 1.2 to 1.3 in the documentation, Makefile, kubebuilder config files and our example deploy.yaml Signed-off-by: Jens Freimann <jfreimann@redhat.com>
cf9a8e5
to
7281b4a
Compare
/retest |
@jensfr: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@@ -3,7 +3,7 @@ | |||
# To re-generate a bundle for another specific version without changing the standard setup, you can: | |||
# - use the VERSION as arg of the bundle target (e.g make bundle VERSION=0.0.2) | |||
# - use environment variables to overwrite this value (e.g export VERSION=0.0.2) | |||
VERSION ?= 1.2.0 | |||
VERSION ?= latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jensfr can you please change this to 1.3.0 as well. My mistake in suggesting latest
. Really sorry for the multiple iterations :-(
Added these changes to #192. |
This patch increases the version number from 1.2 to 1.3 in
the documentation, Makefile, kubebuilder config files and our example
deploy.yaml
Signed-off-by: Jens Freimann jfreimann@redhat.com