kata-monitor DaemonSet: add the "listen-address" arg #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the upstream kata-containers repo the kata-monitor binary is now listening on the loopback address by default: kata-containers/kata-containers@e64c54a2ad7 Since the DaemonSet needs to expose the endpoint to Prometheus, let's specify the "listen-address" argument. This will cause no changes with older/current kata-monitor images but will allow to switch seamlessy to the latest kata-monitor images preserving the availability of the endpoint to Prometheus. Signed-off-by: Francesco Giudici <fgiudici@redhat.com>
|
cc: @littlejawa |
|
NOTE: this is required by https://gitlab.cee.redhat.com/cpaas-midstream/osc-operator/-/merge_requests/41 |
|
/retest |
|
@fgiudici: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
pmores
approved these changes
May 6, 2022
bpradipt
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the upstream kata-containers repo the kata-monitor binary is now
listening on the loopback address by default:
kata-containers/kata-containers@e64c54a2ad7
Since the DaemonSet needs to expose the endpoint to Prometheus, let's
specify the "listen-address" argument.
This will cause no changes with older/current kata-monitor images but
will allow to switch seamlessy to the latest kata-monitor images
preserving the availability of the endpoint to Prometheus.