Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some error paths in the controller #197

Merged
merged 2 commits into from Jun 3, 2022
Merged

Fix some error paths in the controller #197

merged 2 commits into from Jun 3, 2022

Conversation

gkurz
Copy link
Member

@gkurz gkurz commented Jun 3, 2022

The recently introduced createScc() is missing an error path. Same issue exists in createRuntimeClass(). Fix both.

Signed-off-by: Greg Kurz groug@kaod.org

@openshift-ci openshift-ci bot requested review from bpradipt and jensfr June 3, 2022 10:29
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 3, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 3, 2022

Hi @gkurz. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bpradipt
Copy link
Contributor

bpradipt commented Jun 3, 2022

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2022
gkurz added 2 commits June 3, 2022 13:21
@gkurz
Fix createScc() error path
9b03aab 
Errors from Client.Get() other than IsNotFound are silently ignored
instead of being propagated to the caller. Reorganize the code a bit
and add the missing error path.

Fixes: d8620dc ("Create SCC on KataConfig creation")
Signed-off-by: Greg Kurz <groug@kaod.org>
@gkurz
Fix createRuntimeClass() error path
9e34372 
Errors from Client.Get() other than IsNotFound are silently ignored
instead of being propagated to the caller. Reorganize the code a bit
and add the missing error path.

Signed-off-by: Greg Kurz <groug@kaod.org>
@gkurz gkurz requested a review from pmores June 3, 2022 11:29
pmores
pmores approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@pmores pmores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gkurz !

bpradipt
bpradipt approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @gkurz

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 3, 2022

@gkurz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pmores pmores merged commit c2f5d5c into openshift:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpradipt bpradipt bpradipt approved these changes

@pmores pmores pmores approved these changes

@jensfr jensfr Awaiting requested review from jensfr

Assignees

@bpradipt bpradipt

Labels
lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gkurz @bpradipt @pmores