Add cleanup rules to Makefile #221
Conversation
config/manager/kustomization.yaml
Outdated
| @@ -12,5 +12,4 @@ apiVersion: kustomize.config.k8s.io/v1beta1 | |||
| kind: Kustomization | |||
| images: | |||
| - name: controller | |||
| newName: controller | |||
| newTag: latest | |||
| newName: quay.io/rhgkurz/openshift-sandboxed-containers-operator | |||
There was a problem hiding this comment.
I think this is unrelated to this PR ?
There was a problem hiding this comment.
I think this is unrelated to this PR ?
My bad, I forgot to undo the build changes again before pushing... I hate go for this. :-\
This provides a finer grained way to prune generated files from the
current tree over calling `git clean`. Each target that generates
files gets an associated `${target}-clean` : this provides a clear
view of which target generates what. Only exceptions are downloaded
binaries which all get pruned by a single `bin-clean` target for
the sake of simplicity.
Signed-off-by: Greg Kurz <groug@kaod.org>
|
Prow checks will not pass currently. use {slash}override to overcome this. |
|
/override |
|
@gkurz: /override requires failed status contexts to operate on, but none was given In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/4.9-ci-index-sandboxed-containers-operator-bundle ci/prow/4.9-images ci/prow/4.9-sandboxed-containers-operator-e2e ci/prow/ci-index-sandboxed-containers-operator-bundle ci/prow/images ci/prow/sandboxed-containers-operator-e2e pull-ci-openshift-sandboxed-containers-operator-master-4.9-ci-index-sandboxed-containers-operator-bundle |
|
@gkurz: gkurz unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/4.9-ci-index-sandboxed-containers-operator-bundle ci/prow/4.9-images ci/prow/4.9-sandboxed-containers-operator-e2e ci/prow/ci-index-sandboxed-containers-operator-bundle ci/prow/images ci/prow/sandboxed-containers-operator-e2e pull-ci-openshift-sandboxed-containers-operator-master-4.9-ci-index-sandboxed-containers-operator-bundle |
|
@jensfr: Overrode contexts on behalf of jensfr: ci/prow/4.9-ci-index-sandboxed-containers-operator-bundle, ci/prow/4.9-images, ci/prow/4.9-sandboxed-containers-operator-e2e, ci/prow/ci-index-sandboxed-containers-operator-bundle, ci/prow/images, ci/prow/sandboxed-containers-operator-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@gkurz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This provides a finer grained way to prune generated files from the current tree over calling
git clean. Each target that generates files gets an associated${target}-clean: this provides a clear view of which target generates what. Only exceptions are downloaded binaries which all get pruned by a singlebin-cleantarget for the sake of simplicity.Signed-off-by: Greg Kurz groug@kaod.org
- Description of the problem which is fixed/What is the use case
- What I did
- How to verify it
- Description for the changelog