Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bundle.Dockerfile #227

Merged

Conversation

cpmeadors
Copy link
Contributor

@cpmeadors cpmeadors commented Nov 2, 2022

Nothing expects this auto-generated file to exist so we don't need to track it

Closes: KATA-1835

@openshift-ci openshift-ci bot requested review from bpradipt and gkurz November 2, 2022 17:06
@gkurz
Copy link
Member

gkurz commented Nov 2, 2022

@cpmeadors shouldn't bundle.Dockerfile be added back to .gitignore as well ?

@cpmeadors
Copy link
Contributor Author

/test 4.9-ci-index-sandboxed-containers-operator-bundle

@cpmeadors
Copy link
Contributor Author

I restarted the 4.9 bundle build, but I think it is obsolete and we should just waive it if it doesn't pass, which it will since I would need to change it to point to the custom bundle dockerfile as well. I plan on removing it when I update the master file to 4.12 configuration.

@pmores
Copy link
Contributor

pmores commented Nov 3, 2022

@cpmeadors shouldn't bundle.Dockerfile be added back to .gitignore as well ?

Yes, that sounds reasonable to me.

@pmores
Copy link
Contributor

pmores commented Nov 3, 2022

I restarted the 4.9 bundle build, but I think it is obsolete and we should just waive it if it doesn't pass, which it will since I would need to change it to point to the custom bundle dockerfile as well. I plan on removing it when I update the master file to 4.12 configuration.

This seems to be part of a bigger problem which is that the CI as a whole appears effectively unmaintained.

Copy link
Member

@gkurz gkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @cpmeadors !

@cpmeadors
Copy link
Contributor Author

/override 4.9-ci-index-sandboxed-containers-operator-bundle

@openshift-ci
Copy link

openshift-ci bot commented Nov 3, 2022

@cpmeadors: cpmeadors unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight.

In response to this:

/override 4.9-ci-index-sandboxed-containers-operator-bundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gkurz
Copy link
Member

gkurz commented Nov 3, 2022

/override 4.9-ci-index-sandboxed-containers-operator-bundle

@openshift-ci
Copy link

openshift-ci bot commented Nov 3, 2022

@gkurz: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • 4.9-ci-index-sandboxed-containers-operator-bundle

Only the following failed contexts/checkruns were expected:

  • ci/prow/4.9-ci-index-sandboxed-containers-operator-bundle
  • ci/prow/4.9-images
  • ci/prow/4.9-sandboxed-containers-operator-e2e
  • ci/prow/ci-index-sandboxed-containers-operator-bundle
  • ci/prow/images
  • ci/prow/sandboxed-containers-operator-e2e
  • pull-ci-openshift-sandboxed-containers-operator-master-4.9-ci-index-sandboxed-containers-operator-bundle
  • pull-ci-openshift-sandboxed-containers-operator-master-4.9-images
  • pull-ci-openshift-sandboxed-containers-operator-master-4.9-sandboxed-containers-operator-e2e
  • pull-ci-openshift-sandboxed-containers-operator-master-ci-index-sandboxed-containers-operator-bundle
  • pull-ci-openshift-sandboxed-containers-operator-master-images
  • pull-ci-openshift-sandboxed-containers-operator-master-sandboxed-containers-operator-e2e

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override 4.9-ci-index-sandboxed-containers-operator-bundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gkurz
Copy link
Member

gkurz commented Nov 3, 2022

/override ci/prow/4.9-ci-index-sandboxed-containers-operator-bundle

@openshift-ci
Copy link

openshift-ci bot commented Nov 3, 2022

@gkurz: Overrode contexts on behalf of gkurz: ci/prow/4.9-ci-index-sandboxed-containers-operator-bundle

In response to this:

/override ci/prow/4.9-ci-index-sandboxed-containers-operator-bundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Nov 3, 2022

@cpmeadors: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sandboxed-containers-operator-e2e 83bb856 link false /test sandboxed-containers-operator-e2e
ci/prow/4.9-sandboxed-containers-operator-e2e 83bb856 link false /test 4.9-sandboxed-containers-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @cpmeadors

@bpradipt bpradipt merged commit 9edfa22 into openshift:master Nov 3, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2022
@cpmeadors cpmeadors deleted the KATA-1853-remove-bundle.dockerfile branch November 10, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants