Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OWNERS, add cpmeadors #229

Merged
merged 1 commit into from Nov 9, 2022
Merged

Update OWNERS, add cpmeadors #229

merged 1 commit into from Nov 9, 2022

Conversation

jensfr
Copy link
Contributor

@jensfr jensfr commented Nov 7, 2022

Add @cpmeadors as reviewer and approver

@openshift-ci openshift-ci bot requested review from gkurz and pmores November 7, 2022 15:29
@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Nov 7, 2022
OWNERS Outdated
@@ -3,8 +3,10 @@ reviewers:
- pmores
- bpradipt
- gkurz
- cmeadors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/cmeadors/cpmeadors

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, good catch, it's different on github and slack

@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Nov 8, 2022
Copy link
Member

@gkurz gkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jensfr !

@gkurz
Copy link
Member

gkurz commented Nov 8, 2022

/override ci/prow/4.9-ci-index-sandboxed-containers-operator-bundle

@jensfr
Copy link
Contributor Author

jensfr commented Nov 9, 2022

/override ci/prow/4.9-ci-index-sandboxed-containers-operator-bundle

@openshift-ci
Copy link

openshift-ci bot commented Nov 9, 2022

@jensfr: Overrode contexts on behalf of jensfr: ci/prow/4.9-ci-index-sandboxed-containers-operator-bundle

In response to this:

/override ci/prow/4.9-ci-index-sandboxed-containers-operator-bundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jensfr
Copy link
Contributor Author

jensfr commented Nov 9, 2022

/retest

@gkurz
Copy link
Member

gkurz commented Nov 9, 2022

/retest

@jensfr AFAIK these e2e checks always fail but they aren't required => you can merge right away (I sill don't have super powers)

Edit: still needs one review and I might have just been granted super power. Pls don't merge until I check this out.

@pmores
Copy link
Contributor

pmores commented Nov 9, 2022

Why is this two commits though?

@gkurz
Copy link
Member

gkurz commented Nov 9, 2022

Why is this two commits though?

Second commit is fixing the first one. I'd personally make this a single patch and force-push.

@jensfr
Copy link
Contributor Author

jensfr commented Nov 9, 2022

It's two commits because I made the change via the github web U/I and not my local checkout. I'll squash them.

Add @cpmeadors as reviewer and approver.

Signed-off-by: Jens Freimann <jfreimann@redhat.com>
@gkurz
Copy link
Member

gkurz commented Nov 9, 2022

/override ci/prow/4.9-ci-index-sandboxed-containers-operator-bundle

@openshift-ci
Copy link

openshift-ci bot commented Nov 9, 2022

@gkurz: Overrode contexts on behalf of gkurz: ci/prow/4.9-ci-index-sandboxed-containers-operator-bundle

In response to this:

/override ci/prow/4.9-ci-index-sandboxed-containers-operator-bundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gkurz gkurz merged commit 602913b into master Nov 9, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 9, 2022

@jensfr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.9-sandboxed-containers-operator-e2e 05e0034 link false /test 4.9-sandboxed-containers-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gkurz gkurz deleted the jensfr-patch-2 branch November 28, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants