New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OWNERS, add cpmeadors #229
Conversation
OWNERS
Outdated
@@ -3,8 +3,10 @@ reviewers: | |||
- pmores | |||
- bpradipt | |||
- gkurz | |||
- cmeadors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/cmeadors/cpmeadors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, good catch, it's different on github and slack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @jensfr !
/override ci/prow/4.9-ci-index-sandboxed-containers-operator-bundle |
/override ci/prow/4.9-ci-index-sandboxed-containers-operator-bundle |
@jensfr: Overrode contexts on behalf of jensfr: ci/prow/4.9-ci-index-sandboxed-containers-operator-bundle In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@jensfr AFAIK these e2e checks always fail but they aren't required => you can merge right away (I sill don't have super powers) Edit: still needs one review and I might have just been granted super power. Pls don't merge until I check this out. |
Why is this two commits though? |
Second commit is fixing the first one. I'd personally make this a single patch and force-push. |
It's two commits because I made the change via the github web U/I and not my local checkout. I'll squash them. |
Add @cpmeadors as reviewer and approver. Signed-off-by: Jens Freimann <jfreimann@redhat.com>
d7b7856
to
05e0034
Compare
/override ci/prow/4.9-ci-index-sandboxed-containers-operator-bundle |
@gkurz: Overrode contexts on behalf of gkurz: ci/prow/4.9-ci-index-sandboxed-containers-operator-bundle In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jensfr: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Add @cpmeadors as reviewer and approver