Add controller-tools to go.mod for downstream build #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cpmeadors: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
jensfr
approved these changes
Nov 23, 2022
gkurz
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
Not exactly sure how this will be leveraged downstream but the change doesn't look harmful for upstream builds. I hope it will do the trick @cpmeadors !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Description of the problem which is fixed/What is the use case
Our downstream build process of the operator image has not network access so we need to use the go module caching feature to run controller-gen directly rather than downloading the binary
Required for KATA-1800
- What I did
$ go get sigs.k8s.io/controller-tools/cmd/controller-gen@v0.8.0- How to verify it
$ go mod download$ go run sigs.k8s.io/controller-tools/cmd/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."THis should generate the same files as running make generate does.
- Description for the changelog