Update to operator-sdk 1.21.0

[littlejawa]

Following steps from https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.21.0/

• Makefile: replace "go get" calls with "go install" calls (copy/paste of a code snippet)
• manager_auth_proxy_path.yaml: update kube-rbac-proxy version
• go.mod/go.sum changes according to the steps + go mod tidy + additional changes to fix build errors

Dockerfile:

• update to go 1.18 to fix build issues
• as there is no 1.18 image for 4.10, use 4.11 image for the builder, and change the base image accordingly
• empty the GOFLAGS variable when calling "make build": the new "go install" commands were failing because of the default "-mod=vendor" flag. The actual build in the makefile is explicitely using "-mod=mod" flag anyway.

Misc:

• update the sdk version in bundle-custom.Dockerfile too
• update the DEVELOPMENT.md file with new versions

[openshift-ci]

Hi @littlejawa. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[littlejawa]

/hold
I have an issue with the webhook when testing this - working on it

[littlejawa]

/unhold
The failure was due to my environment. With a clean setup, I can install the operator and run kata containers.

[littlejawa]

I have a question: we will need to upgrade to 1.23 at least. Should I make separate PRs building one on top of the other, or a single PR, with one commit for each upgrade?

[jensfr]

I have a question: we will need to upgrade to 1.23 at least. Should I make separate PRs building one on top of the other, or a single PR, with one commit for each upgrade?

I think one PR for every upgrade will be easier to review

[jensfr]

/ok-to-test

[jensfr]

I think we use the digest instead of tag here so that it can work in disconnected environments

[littlejawa]

Fixed. Thanks!

[jensfr]

lgtm, thanks @littlejawa
@cpmeadors, @beraldoleal installing kustomize has changed, that may affect our downstream scripts

[littlejawa]

Additional changes:

• fixed CI test jobs: bundle-custom.Dockerfile had to be modified in the same way as Dockerfile to call "make" with no GOFLAGS set
• also in bundle-custom.Dockerfile: use the same builder image as in Dockerfile for consistency
• reference the image by digest rather than version in manager_auth_proxy_patch.yaml

[openshift-ci]

@littlejawa: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/sandboxed-containers-operator-e2e	f725438	link	false	/test sandboxed-containers-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[cpmeadors]

All changes look good