Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to operator-sdk 1.23.0 #237

Merged
merged 1 commit into from Dec 6, 2022
Merged

Update to operator-sdk 1.23.0 #237

merged 1 commit into from Dec 6, 2022

Conversation

littlejawa
Copy link
Contributor

Following steps from https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.23.0/

Makefile:

  • do not download binaries when they are found already
  • update controller-tools to 0.9.2
  • update kustomize to 4.5.5

go.mod:

  • update controller-runtime to 0.12.2
  • update kubernetes dependencies to 0.24.2
  • make sure controller-tools is still there, and updated to 0.9.2

manager_auth_proxy_patch.yaml:

  • update kube-rbac-proxy to 0.13.0 (using digest)

config/default/kustomization.yaml:

  • changes related to updating to kustomize 4.5.5

misc:

  • updated developper's doc
  • modified bundle-custom.Dockerfile to use operator-sdk 1.23

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2022
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Dec 2, 2022

Hi @littlejawa. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpmeadors
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 2, 2022
@littlejawa
Copy link
Contributor Author

I'm marking it "WIP" because I've not been able to test it.
When installing kataconfig, I get an error:
Error "failed calling webhook "vkataconfig.kb.io": failed to call webhook: Post "https://controller-manager-service.openshift-sandboxed-containers-operator.svc:443/validate-kataconfiguration-openshift-io-v1-kataconfig?timeout=10s": no endpoints available for service "controller-manager-service"" for field "undefined".

Building / installing the operator from "main" just works, so the error seems to be related to the changes in this PR.

I don't know what's wrong. Maybe it's related to the update in kustomize (there is a warning in the document about that, but I don't understand the details).
Putting it there to get other eyes on it, and get it tested on the CI (outside of my own environment) just to see if it is better.
I'll continue digging into it until I get it to work.

cpmeadors
cpmeadors approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@cpmeadors cpmeadors left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good based on sdk update doc. controller-gen is still in go.mod.

@jensfr
Copy link
Contributor

jensfr commented Dec 5, 2022

I'm marking it "WIP" because I've not been able to test it. When installing kataconfig, I get an error: Error "failed calling webhook "vkataconfig.kb.io": failed to call webhook: Post "https://controller-manager-service.openshift-sandboxed-containers-operator.svc:443/validate-kataconfiguration-openshift-io-v1-kataconfig?timeout=10s": no endpoints available for service "controller-manager-service"" for field "undefined".

Building / installing the operator from "main" just works, so the error seems to be related to the changes in this PR.

I don't know what's wrong. Maybe it's related to the update in kustomize (there is a warning in the document about that, but I don't understand the details). Putting it there to get other eyes on it, and get it tested on the CI (outside of my own environment) just to see if it is better. I'll continue digging into it until I get it to work.

We usually see that error when the controller pod is not running. what does `oc describe pod say?

jensfr
jensfr reviewed Dec 5, 2022
View reviewed changes
config/default/manager_auth_proxy_patch.yaml Outdated
@@ -10,7 +10,7 @@ spec:
spec:
containers:
- name: kube-rbac-proxy
image: gcr.io/kubebuilder/kube-rbac-proxy@sha256:a4f6c39b17f2ba68366c6d4e139ed18ede2ad9f3f9d5bf7477bdcbef73b43e54
image: gcr.io/kubebuilder/kube-rbac-proxy@sha256:31eb553d98f6b81054babf56b952f7f2f4b56e1c782e2da4feb6ab5247bd288c
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder to double check this digest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, my bad. I got the wrong one.
Fixed.

@littlejawa
Update to operator-sdk 1.23.0
3304e42 
Following steps from https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.23.0/

Signed-off-by: Julien Ropé <jrope@redhat.com>
@littlejawa littlejawa changed the title [WIP] Update to operator-sdk 1.23.0 Update to operator-sdk 1.23.0 Dec 5, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2022
@littlejawa
Copy link
Contributor Author

Fixed the digest for kube-rbac-proxy v0.13.0, and I could test it successfully.
Thanks for the help :)

@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2022

@littlejawa: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sandboxed-containers-operator-e2e 3304e42 link false /test sandboxed-containers-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jensfr
jensfr approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@jensfr jensfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you @littlejawa

@jensfr jensfr merged commit 4094a14 into openshift:main Dec 6, 2022
@littlejawa littlejawa deleted the upgrade_operator_sdk_123 branch December 8, 2022 15:42
@littlejawa littlejawa mentioned this pull request Jan 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensfr jensfr jensfr approved these changes

@cpmeadors cpmeadors cpmeadors approved these changes

@bpradipt bpradipt Awaiting requested review from bpradipt

Assignees
No one assigned
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@littlejawa @cpmeadors @jensfr