Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: Target bundle-build requires bundle #257

Merged
merged 1 commit into from Feb 2, 2023
Merged

Makefile: Target bundle-build requires bundle #257

merged 1 commit into from Feb 2, 2023
+1 −1

Conversation

etrunko
Copy link
Contributor

@etrunko etrunko commented Jan 27, 2023 •
edited

- Description of the problem which is fixed/What is the use case

If one calls make bundle-build without a make bundle beforehand, it will error out:

$ make bundle-build
docker build -f bundle.Dockerfile -t openshift-sandboxed-containers-operator-bundle:v1.3.2 .
unable to prepare context: unable to evaluate symlinks in Dockerfile path: lstat sandboxed-containers-operator/bundle.Dockerfile: no such file or directory

- What I did

Added bundle as dependency of bundle-build

- How to verify it

Run make bundle-build without calling make bundle beforehand.

- Description for the changelog
Makefile: Target bundle-build requires bundle

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2023

Hi @etrunko. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jensfr
Copy link
Contributor

jensfr commented Jan 30, 2023

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 30, 2023
@cpmeadors
Copy link
Contributor

/override ci/prow/sandboxed-containers-operator-e2e

@openshift-ci
Copy link

openshift-ci bot commented Feb 1, 2023

@cpmeadors: Overrode contexts on behalf of cpmeadors: ci/prow/sandboxed-containers-operator-e2e

In response to this:

/override ci/prow/sandboxed-containers-operator-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cpmeadors
cpmeadors reviewed Feb 1, 2023
View reviewed changes
Copy link
Contributor

@cpmeadors cpmeadors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out your branch and make sure the make bundle-build worked after a make clean. Build succeeded, but I noticed that the tag was still 1.3.2. Not sure where that is coming from but maybe a rebase is needed. Otherwise it looks good.

@etrunko
Makefile: Target bundle-build requires bundle
1913881 
If one calls make bundle-build without a make bundle beforehand, it will
error out:

$ make bundle-build
docker build -f bundle.Dockerfile -t openshift-sandboxed-containers-operator-bundle:v1.3.2 .
unable to prepare context: unable to evaluate symlinks in Dockerfile path: lstat sandboxed-containers-operator/bundle.Dockerfile: no such file or directory

Signed-off-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
@etrunko
Copy link
Contributor Author

etrunko commented Feb 1, 2023

Rebased to latest main, it should get 1.3.3 version now.

@openshift-ci
Copy link

openshift-ci bot commented Feb 1, 2023

@etrunko: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sandboxed-containers-operator-e2e 1913881 link false /test sandboxed-containers-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jensfr
jensfr approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@jensfr jensfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @etrunko

littlejawa
littlejawa approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@littlejawa littlejawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

gkurz
gkurz approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@gkurz gkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @etrunko !

@gkurz gkurz merged commit 0f1e61f into openshift:main Feb 2, 2023
@etrunko etrunko deleted the makefile-bundle branch February 2, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeadors cpmeadors cpmeadors left review comments

@jensfr jensfr jensfr approved these changes

@littlejawa littlejawa littlejawa approved these changes

@gkurz gkurz gkurz approved these changes

@bpradipt bpradipt Awaiting requested review from bpradipt

Assignees
No one assigned
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@etrunko @jensfr @cpmeadors @littlejawa @gkurz