Encode log timestamps as RFC3339 #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timestamps are currently displayed as number of seconds since the Epoch using scientific notation, i.e. 1.6759526089944808e+09. This is definitely not human friendly. Newer versions of the zap package now render timestamps according to RFC3339, i.e. 2023-02-09T14:38:20Z. We're not ready to bump the controller-runtime package that brings us zap. Let's configure zap to explicitly use RFC3339. Signed-off-by: Greg Kurz <groug@kaod.org>
pmores
approved these changes
Feb 9, 2023
|
@gkurz: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timestamps are currently displayed as number of seconds since the Epoch using scientific notation, i.e. 1.6759526089944808e+09.
This is definitely not human friendly. Newer versions of the zap package now render timestamps according to RFC3339, i.e. 2023-02-09T14:38:20Z.
We're not ready to bump the controller-runtime package that brings us zap. Let's configure zap to explicitly use RFC3339.
Signed-off-by: Greg Kurz groug@kaod.org
- Description of the problem which is fixed/What is the use case
- What I did
- How to verify it
- Description for the changelog