New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update operator SDK instructions. #264
Update operator SDK instructions. #264
Conversation
Hi @smuda. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @smuda
/retest |
@smuda: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@smuda: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@bpradipt Is it possible the e2e tests are a bit flunky? Both in this PR (where I only updated the markdown instructions) and #266 the same tests are failing. Where are the e2e tests defined? I can't seem to find them in the repo and there is no information i DEVELOPMENT.md |
@smuda yeah the tests are broken. The tests are here - https://github.com/openshift/release/tree/master/ci-operator/jobs/kata-containers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @smuda
- Description of the problem which is fixed/What is the use case
The instructions for downloading the operator SDK was updated from operator SDK home page.
Fixes #263
- What I did
Updated the instructions.
- How to verify it
Follow the instructions. Notice that the file now is more than 0 bytes and also is an executable.
- Description for the changelog
Nope. I don't think this should be inserted into the changelog.