Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update operator SDK instructions. #264

Merged

Conversation

smuda
Copy link
Contributor

@smuda smuda commented Feb 27, 2023

- Description of the problem which is fixed/What is the use case

The instructions for downloading the operator SDK was updated from operator SDK home page.

Fixes #263

- What I did

Updated the instructions.

- How to verify it

Follow the instructions. Notice that the file now is more than 0 bytes and also is an executable.

- Description for the changelog

Nope. I don't think this should be inserted into the changelog.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 27, 2023
@openshift-ci openshift-ci bot requested review from gkurz and pmores February 27, 2023 18:24
@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2023

Hi @smuda. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @smuda

@bpradipt bpradipt requested a review from littlejawa March 1, 2023 11:41
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2023
@smuda
Copy link
Contributor Author

smuda commented Mar 1, 2023

/retest

@openshift-ci
Copy link

openshift-ci bot commented Mar 1, 2023

@smuda: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smuda smuda changed the title Update operator SDK instructions. Fixes #263 Update operator SDK instructions. Mar 1, 2023
@bpradipt
Copy link
Contributor

bpradipt commented Mar 2, 2023

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 2, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 2, 2023

@smuda: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sandboxed-containers-operator-e2e 29ca8fc link false /test sandboxed-containers-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smuda
Copy link
Contributor Author

smuda commented Mar 2, 2023

@bpradipt Is it possible the e2e tests are a bit flunky? Both in this PR (where I only updated the markdown instructions) and #266 the same tests are failing.

Where are the e2e tests defined? I can't seem to find them in the repo and there is no information i DEVELOPMENT.md

@bpradipt
Copy link
Contributor

bpradipt commented Mar 3, 2023

@bpradipt Is it possible the e2e tests are a bit flunky? Both in this PR (where I only updated the markdown instructions) and #266 the same tests are failing.

Where are the e2e tests defined? I can't seem to find them in the repo and there is no information i DEVELOPMENT.md

@smuda yeah the tests are broken. The tests are here - https://github.com/openshift/release/tree/master/ci-operator/jobs/kata-containers

Copy link
Contributor

@littlejawa littlejawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Thanks @smuda

@bpradipt bpradipt merged commit 658e9a0 into openshift:main Mar 3, 2023
@smuda smuda deleted the bugfix/update-sdk-download-instructions branch March 3, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instructions for downloading operator SDK is outdated.
3 participants