Reformat go code #290
Merged
Reformat go code #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most target in the makefile, e.g. 'make test' or 'make build', internally invoke 'make fmt' which reformats all the go code. Despite of that, badly formatted go code landed in the repo. This causes unrelated changes to appear in local repos during regular development. This is quite irritating for picky(?) people who don't want to push alien changes in their PRs. A long term solution would be that the gating CI catch these nits upfront. They are a variety of solutions available to developers to run 'go fmt' in their environement before pushing code. In the meantime, fix the current code base. This obviously doesn't change any behavior. Signed-off-by: Greg Kurz <groug@kaod.org>
pmores
approved these changes
Apr 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most target in the makefile, e.g. 'make test' or 'make build', internally invoke 'make fmt' which reformats all the go code.
Despite of that, badly formatted go code landed in the repo. This causes unrelated changes to appear in local repos during regular development. This is quite irritating for picky(?) people who don't want to push alien changes in their PRs.
A long term solution would be that the gating CI catches those nits upfront. They are a variety of solutions available to developers to run 'go fmt' in their environement before pushing changes.
In the meantime, fix the current code base. This obviously doesn't change any behavior.
No testing required.