Add controller tools back

[jensfr]

• Description of the problem which is fixed/What is the use case
  Downstream Red Hat builds require controller-tools to be in the go.mod so they can be cached due to network limitations. They can easily be removed accidentally with go mod tidy because they are not actually dependencies.

• What I did
  go get sigs.k8s.io/controller-tools@v0.9.2
  go get sigs.k8s.io/controller-tools/pkg/genall/help/pretty@v0.9.2
  go get sigs.k8s.io/controller-tools/pkg/crd@v0.9.2
  Edit: had to also do this (Greg)
  go get sigs.k8s.io/controller-tools/cmd/controller-gen@v0.9.2

• How to verify it
  go run sigs.k8s.io/controller-tools/cmd/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./...""

• Description for the changelog

[cpmeadors]

I did a go mod download and then ran

go run sigs.k8s.io/controller-tools/cmd/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."

and got

../../../../go/pkg/mod/sigs.k8s.io/controller-tools@v0.9.2/cmd/controller-gen/main.go:25:2: missing go.sum entry for module providing package github.com/spf13/cobra (imported by sigs.k8s.io/controller-tools/cmd/controller-gen); to add:
go get sigs.k8s.io/controller-tools/cmd/controller-gen@v0.9.2

This is from a brand new clone of sandboxed-container-operator with the PR branch checked out. Either something changed or I missed a go get command the last time. Not sure why we didn't see this previously. Maybe everyone had a dirty test env.

[jensfr]

I don't see that problem, even with a fresh checkout

[openshift-ci]

@jensfr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/sandboxed-containers-operator-e2e	4560e24	link	false	/test sandboxed-containers-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[bpradipt]

/lgtm
Thanks @jensfr

[bpradipt]

Added a reference issue to fix it in code - #294

[gkurz]

I did a go mod download and then ran

go run sigs.k8s.io/controller-tools/cmd/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."

and got

../../../../go/pkg/mod/sigs.k8s.io/controller-tools@v0.9.2/cmd/controller-gen/main.go:25:2: missing go.sum entry for module providing package github.com/spf13/cobra (imported by sigs.k8s.io/controller-tools/cmd/controller-gen); to add: go get sigs.k8s.io/controller-tools/cmd/controller-gen@v0.9.2

I hit exactly the same error and if I do go get sigs.k8s.io/controller-tools/cmd/controller-gen@v0.9.2 as suggested in the error then the test succeeds. This go get command simply adds github.com/inconshreveable/mousetrap and github.com/spf13/cobra as indirect dependencies. @jensfr do you see them in your go.mod ?

This is from a brand new clone of sandboxed-container-operator with the PR branch checked out. Either something changed or I missed a go get command the last time. Not sure why we didn't see this previously. Maybe everyone had a dirty test env.

@cpmeadors I've reset hard to the merge commit of #286 :

$ git reset --hard e54c02c47f05016f294113bce66d48f8af2909b4
HEAD is now at e54c02c47f05 Merge pull request #286 from cpmeadors/add-back-controller-tools-for-downstream-builds
$ git grep -E 'cobra|mouse' go.mod
go.mod: github.com/inconshreveable/mousetrap v1.0.1 // indirect
go.mod: github.com/spf13/cobra v1.6.0 // indirect

It seems that the extra go get wasn't needed back then but it is now because 6577693 removed them.

[jensfr]

Travelling back today and probably won't get to this. Feel free to send another PR to fix this

[openshift-ci]

New changes are detected. LGTM label has been removed.

[gkurz]

Travelling back today and probably won't get to this. Feel free to send another PR to fix this

Since your PR has Maintainers are allowed to edit this pull request., I could simply force-push the fix to your branch 😉

[jensfr]

Nice, thank you @gkurz