Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include a direct dependency to controller-tools. #296

Merged
merged 1 commit into from Apr 25, 2023
Merged

Include a direct dependency to controller-tools. #296

merged 1 commit into from Apr 25, 2023

Conversation

bpradipt
Copy link
Contributor

This is backporting the fix for #294 from main to peer-pods-tech-preview branch

@bpradipt
Include a direct dependency to controller-tools.
7bf476c 
controller-tools is required for manifest generation and
for downstream builds we need to cache all the modules.
Consequently all the required modules should be in go.mod

Fixes: openshift#294
Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
@bpradipt bpradipt requested a review from jensfr April 25, 2023 10:11
jensfr
jensfr reviewed Apr 25, 2023
View reviewed changes
Copy link
Contributor

@jensfr jensfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bpradipt

gkurz
gkurz approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@gkurz gkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bpradipt !

@bpradipt bpradipt merged commit 6a1b3ca into openshift:peer-pods-tech-preview Apr 25, 2023
@bpradipt bpradipt deleted the tp-fix-294 branch April 25, 2023 14:27
bpradipt added a commit to bpradipt/sandboxed-containers-operator that referenced this pull request Apr 25, 2023
@bpradipt
Revert "Merge pull request openshift#296 from bpradipt/tp-fix-294"
0e701cd 
This reverts commit 6a1b3ca, reversing
changes made to 611d9f9.

This is not a complete fix for downstream builds and hence reverting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensfr jensfr jensfr approved these changes

@gkurz gkurz gkurz approved these changes

@littlejawa littlejawa Awaiting requested review from littlejawa

@pmores pmores Awaiting requested review from pmores

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bpradipt @jensfr @gkurz