Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller: fix incorrect logs in createAuthJsonSecret #304

Merged

Conversation

esposem
Copy link
Contributor

@esposem esposem commented May 2, 2023

 controller: fix incorrect logs in createAuthJsonSecret
    
    If the client is just updated with no error, the code was always falling
    back to r.Log.Info("Error creating auth-json-secret", "err", err)
    thus printing it also when it was not necessary.
    
    Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>

If the client is just updated with no error, the code was always falling
back to r.Log.Info("Error creating auth-json-secret", "err", err)
thus printing it also when it was not necessary.

Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
@openshift-ci openshift-ci bot requested review from cpmeadors and gkurz May 2, 2023 08:05
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 2, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 2, 2023

Hi @esposem. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bpradipt
Copy link
Contributor

bpradipt commented May 3, 2023

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 3, 2023
Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @esposem

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2023
@bpradipt bpradipt merged commit 60f6fea into openshift:peer-pods-tech-preview May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants