add image creation jobs for aws and azure #306
Merged
+166
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpradipt
reviewed
May 10, 2023
bpradipt
reviewed
May 10, 2023
bpradipt
reviewed
May 10, 2023
hack/aws-image-job.yaml
Outdated
| value: "t2.small" # comment | ||
| - name: IMAGE_NAME | ||
| value: "peer-pod-ami" | ||
| # - name: AWS_REGION |
There was a problem hiding this comment.
Let's take this from the secret/configmap
There was a problem hiding this comment.
IMAGE_NAME is not used by peerpods, hence this parameter needs to be set specifically for the image creation, I'll do export IMAGE_NAME=${IMAGE_NAME:-peer-pod-ami} instead
There was a problem hiding this comment.
@snir911 can you please remove the AWS_REGION, VPC_ID and SUBNET_ID parameters from the manifest. This is coming from the configmap/secret, so let's avoid mentioning it here.
bpradipt
reviewed
May 10, 2023
bpradipt
reviewed
May 10, 2023
bpradipt
reviewed
May 10, 2023
bpradipt
reviewed
May 10, 2023
bpradipt
reviewed
May 10, 2023
bpradipt
reviewed
May 10, 2023
snir911
force-pushed
the
img_jobs_tp2
branch
2 times, most recently
from
b1398b0
to
7f0bea0
Compare
bpradipt
reviewed
May 10, 2023
snir911
force-pushed
the
img_jobs_tp2
branch
6 times, most recently
from
88e6360
to
d9a50ce
Compare
bpradipt
approved these changes
May 15, 2023
cloud providers Signed-off-by: Snir Sheriber <ssheribe@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apply scripts to create image in AWS/Azure